Re: [PATCH][RESEND 3] disassociate_ctty SMP fix

[Andrew Morton <akpm@digeo.com>]

Rik van Riel <riel@conectiva.com.br> wrote:
>
> ===== drivers/char/tty_io.c 1.55 vs edited =====
> --- 1.55/drivers/char/tty_io.c	Tue Jan 14 23:37:20 2003
> +++ edited/drivers/char/tty_io.c	Tue Feb  4 23:02:52 2003
> @@ -425,19 +425,21 @@
>   */
>  void do_tty_hangup(void *data)
>  {
> -	struct tty_struct *tty = (struct tty_struct *) data;
> +	struct tty_struct *tty;
>  	struct file * cons_filp = NULL;
>  	struct task_struct *p;
>  	struct list_head *l;
>  	struct pid *pid;
>  	int    closecount = 0, n;
> 
> -	if (!tty)
> -		return;
> -
>  	/* inuse_filps is protected by the single kernel lock */
>  	lock_kernel();
> -
> +	tty = (struct tty_struct *) data;
> +	if (!tty) {
> +		unlock_kernel();
> +		return;
> +	}
> +
>  	check_tty_count(tty, "do_tty_hangup");
>  	file_list_lock();
>  	for (l = tty->tty_files.next; l != &tty->tty_files; l = l->next) {

This part is a no-op...