From: Patrick Mansfield <patmans@us.ibm.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Christoph Hellwig <hch@lst.de>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fixes and cleanups for the new command allocation code
Date: Tue, 4 Feb 2003 21:15:16 -0800 [thread overview]
Message-ID: <20030204211516.A30419@beaverton.ibm.com> (raw)
In-Reply-To: <1044410039.3485.61.camel@mulgrave>; from James.Bottomley@steeleye.com on Tue, Feb 04, 2003 at 07:53:57PM -0600
On Tue, Feb 04, 2003 at 07:53:57PM -0600, James Bottomley wrote:
> On Tue, 2003-02-04 at 19:25, Patrick Mansfield wrote:
> But that's not how the block queue works: prep is actually called from
> elv_next_request(). Therefore, if you plug the queue in the request
> function when you're over the queue limit, you only get a single fully
> prepped request waiting in the queue, which, I think, is the desired
> behaviour. Even if the queue is restarted because of I/O pressure, it
> will begin with the prepped request and re-block.
OK that sounds great, except we should not plug the queue since we
have outstanding IO.
> And the slave_{alloc,configure,destroy} needs fixing too.
What is broken?
-- Patrick Mansfield
next prev parent reply other threads:[~2003-02-05 5:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-04 15:23 [PATCH] fixes and cleanups for the new command allocation code Christoph Hellwig
2003-02-04 16:16 ` Patrick Mansfield
2003-02-04 16:51 ` Christoph Hellwig
2003-02-04 17:19 ` Patrick Mansfield
2003-02-04 17:57 ` Luben Tuikov
2003-02-04 18:03 ` Christoph Hellwig
2003-02-04 18:08 ` Luben Tuikov
2003-02-04 18:33 ` James Bottomley
2003-02-04 19:29 ` Christoph Hellwig
2003-02-04 23:03 ` James Bottomley
2003-02-05 1:25 ` Patrick Mansfield
2003-02-05 1:53 ` James Bottomley
2003-02-05 5:15 ` Patrick Mansfield [this message]
2003-02-05 15:22 ` James Bottomley
2003-02-05 15:59 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030204211516.A30419@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.