All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Drokin <green@linuxhacker.ru>
To: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: 2.4.21-pre4 more extra semicolons bugs
Date: Sun, 9 Feb 2003 19:54:08 +0300	[thread overview]
Message-ID: <20030209165408.GA19368@linuxhacker.ru> (raw)
In-Reply-To: <20030208171838.GA2230@linuxhacker.ru>

Hello!

    It is a boring sunday here today, so I decided to play with gcc -W
    on a 2.4.21-pre4 (from current bitkeeper tree) with all the stuff
    possible compiled in.
    Seems that megaraid and 8253xtty have extra semicolons. Nothing
    too serious, though.

Bye,
    Oleg
===== drivers/net/wan/8253x/8253xtty.c 1.1 vs edited =====
--- 1.1/drivers/net/wan/8253x/8253xtty.c	Thu Apr  4 23:05:10 2002
+++ edited/drivers/net/wan/8253x/8253xtty.c	Sun Feb  9 19:32:58 2003
@@ -2131,7 +2131,7 @@
 	/* Check whether or not the port is open in SYNC mode */
 	if(port->open_type == OPEN_SYNC_NET)
 	{
-		if(port->dev && netif_carrier_ok(port->dev));
+		if(port->dev && netif_carrier_ok(port->dev))
 		{
 			port->tty= NULL;	/* Don't bother with open counting here
 						   but make sure the tty field is NULL*/
===== drivers/scsi/megaraid.c 1.21 vs edited =====
--- 1.21/drivers/scsi/megaraid.c	Fri Dec 13 12:29:59 2002
+++ edited/drivers/scsi/megaraid.c	Sun Feb  9 19:39:12 2003
@@ -4936,7 +4936,7 @@
 		if( ioc.mbox[0] == MEGA_MBOXCMD_PASSTHRU ) {
 			put_user( scsicmd->result, &uioc->pthru.scsistatus );
 			if (copy_to_user( uioc->pthru.reqsensearea, scsicmd->sense_buffer,
-							  MAX_REQ_SENSE_LEN ));
+							  MAX_REQ_SENSE_LEN ))
 				ret= -EFAULT;
 		} else {
 			put_user(1, &uioc->mbox[16]);	/* numstatus */

  parent reply	other threads:[~2003-02-09 16:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-08 17:18 2.4.21-pre4 comparison bugs Oleg Drokin
2003-02-08 23:25 ` J.A. Magallon
2003-02-17  2:10   ` Bill Davidsen
2003-02-09  0:58 ` Alan Cox
2003-02-09 17:53   ` 2.4.21-pre4 comparison bugs (More of those) Oleg Drokin
2003-02-09 18:22     ` 2.4.21-pre4 comparison bugs (Even More Again) Oleg Drokin
2003-02-09 21:59       ` Alan Cox
2003-02-09 22:01     ` 2.4.21-pre4 comparison bugs (More of those) Alan Cox
2003-02-10  7:06       ` Oleg Drokin
2003-02-09 16:54 ` Oleg Drokin [this message]
2003-02-09 16:59   ` 2.4.21-pre4 - two simple compile fixes Oleg Drokin
2003-02-09 22:02     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030209165408.GA19368@linuxhacker.ru \
    --to=green@linuxhacker.ru \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.