All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Vilain <sam@vilain.net>
To: Oleg Drokin <green@namesys.com>
Cc: reiserfs-list@namesys.com, vitaly@namesys.com
Subject: Re: reiserfsck --blame-it-on-the-hardware-yeah-yeah
Date: Tue, 11 Feb 2003 15:53:48 +1300	[thread overview]
Message-ID: <200302111553.48409.sam@vilain.net> (raw)
In-Reply-To: <20030210161132.A15924@namesys.com>

On Tue, 11 Feb 2003 02:11, Oleg Drokin wrote:
> > You need to do one, preferably both of the following:
> >   a) allow reiserfsck to ignore the in-partition journal, without
> > producing an insane result (where the filesystem header says there is
> > a journal, but the space where the journal is has filesystem data in
> > it).
>
> This cannot happen in any sane way. (I mean root block just cannot live
> in journal).

Yes.  That's what happened when reiserfsck ran with the simple hack I 
detailed.  Granted, that violated a sanity condition of your code, with 
insane results.  GIGO.

I don't care how - there just needs to be some easy way to clear or ignore 
a corrupted journal.  With that junk in there and no `Oh, that's simple, 
just dd /dev/zero to ...' instructions on clearing the journal, I had no 
other option but to try a hack.

If you were to consider the --no-journal-available flag to mean 
--ignore-journal-contents when running with a Journal Inside(tm) 
filesystem, then presumably you would add corresponding changes to the 
code to make sure you don't end up trying to put superblocks in journal 
space.

While we're on the subject of reiserfs bugs, simply running `cddump' on my 
system created bogus directory entries I couldn't remove (on vanilla 
2.4.20).  It's just doing a (selective) `cp -al' and subsequently removing 
the structures, for 650MB of a filesystem at a time.  This was enough to 
trigger those race conditions, possibly the same as first reported by Zygo 
Blaxell - did you get anywhere with those?
-- 
Sam Vilain, sam@vilain.net

But I also made it clear to (Vladimir Putin) that it's important to
think beyond the old days of when we had the concept that if we blew
each other up, the world would be safe.
 - George W. Bush, May 1, 2001

      reply	other threads:[~2003-02-11  2:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-08  0:50 reiserfsck --blame-it-on-the-hardware-yeah-yeah Sam
2003-02-08 10:20 ` Oleg Drokin
     [not found]   ` <20030208224928.A30012@ns.soreal.co.uk>
2003-02-09 10:01     ` Oleg Drokin
2003-02-10 16:24       ` Sam Vilain
2003-02-10 13:11         ` Oleg Drokin
2003-02-11  2:53           ` Sam Vilain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200302111553.48409.sam@vilain.net \
    --to=sam@vilain.net \
    --cc=green@namesys.com \
    --cc=reiserfs-list@namesys.com \
    --cc=vitaly@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.