From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Ballabio_Dario@emc.com, manfred@colorfullife.com,
warp@mercury.d2dc.net,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: eata irq abuse (was: Re: Linux 2.5.60)
Date: Wed, 12 Feb 2003 14:51:21 +0000 [thread overview]
Message-ID: <20030212145121.A8963@infradead.org> (raw)
In-Reply-To: <1045060838.1823.7.camel@mulgrave>; from James.Bottomley@steeleye.com on Wed, Feb 12, 2003 at 08:40:34AM -0600
On Wed, Feb 12, 2003 at 08:40:34AM -0600, James Bottomley wrote:
> > Ah, you don't need the lock but the disabled interrupts!
>
> In general, that's not correct: most HBA registers have to be accessed
> in sequence, thus you need global protection from anyone else touching
> them while you're at the registers. This is what host_lock was designed
> for.
Of course. but that's not how driver_lock in eata.c works. It's taken
when we enter eata2x_detect(), dropped before scsi_register(), reacquired
afterwards and released when we leave eata2x_detect(). I don't really
see what it is supposed to protect.
next prev parent reply other threads:[~2003-02-12 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 14:13 eata irq abuse (was: Re: Linux 2.5.60) Ballabio_Dario
2003-02-12 14:25 ` Christoph Hellwig
2003-02-12 14:40 ` James Bottomley
2003-02-12 14:51 ` Christoph Hellwig [this message]
2003-02-12 14:54 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2003-02-12 15:37 Ballabio_Dario
2003-02-12 12:47 Ballabio_Dario
2003-02-12 13:17 ` Christoph Hellwig
2003-02-12 10:08 Ballabio_Dario
2003-02-12 15:28 ` Jeff Garzik
2003-02-12 16:03 ` Jeff Garzik
2003-02-12 19:11 ` Suresh Kr N
2003-02-11 17:45 Manfred Spraul
2003-02-11 23:01 ` Zephaniah E. Hull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030212145121.A8963@infradead.org \
--to=hch@infradead.org \
--cc=Ballabio_Dario@emc.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=warp@mercury.d2dc.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.