Re: [PATCHSET] PC-9800 subarch. support for 2.5.60 (12/34) console

[Christoph Hellwig <hch@infradead.org>]

On Wed, Feb 12, 2003 at 10:42:33PM +0900, Osamu Tomita wrote:
> +ifneq ($(CONFIG_X86_PC9800),y)
>  FONTMAPFILE = cp437.uni
> +else
> +FONTMAPFILE = pc9800.uni
> +endif

This should be

ifeq ($(CONFIG_X86_PC9800),y)
FONTMAPFILE = pc9800.uni
else
FONTMAPFILE = cp437.uni
endif

but I really wonder whether there's something nicer possible


> diff -Nru linux/drivers/char/console_macros.h linux98/drivers/char/console_macros.h
> --- linux/drivers/char/console_macros.h	Sat Oct 19 13:01:17 2002
> +++ linux98/drivers/char/console_macros.h	Mon Oct 28 16:53:39 2002
> @@ -55,6 +55,10 @@
>  #define	s_reverse	(vc_cons[currcons].d->vc_s_reverse)
>  #define	ulcolor		(vc_cons[currcons].d->vc_ulcolor)
>  #define	halfcolor	(vc_cons[currcons].d->vc_halfcolor)
> +#define def_attr	(vc_cons[currcons].d->vc_def_attr)
> +#define ul_attr		(vc_cons[currcons].d->vc_ul_attr)
> +#define half_attr	(vc_cons[currcons].d->vc_half_attr)
> +#define bold_attr	(vc_cons[currcons].d->vc_bold_attr)

Bah, console_macros.h should just die.

> diff -Nru linux/drivers/char/console_pc9800.h linux98/drivers/char/console_pc9800.h
> --- linux/drivers/char/console_pc9800.h	Thu Jan  1 09:00:00 1970
> +++ linux98/drivers/char/console_pc9800.h	Mon Oct 28 11:48:10 2002

I think this should all be in include/linux/console.h.

> --- linux/drivers/char/vt.c	2002-12-16 11:08:16.000000000 +0900
> +++ linux98/drivers/char/vt.c	2002-12-20 14:52:06.000000000 +0900
> @@ -75,6 +75,9 @@
>   */
>  
>  #include <linux/module.h>
> +#ifdef CONFIG_X86_PC9800
> +#define CONFIG_KANJI
> +#endif

Please set CONFIG_KANJI in the Kconfig file and in general
the CONFIG_KANJI usere look really messy.  I don't think it's
easy to get them cleaned up before 2.6, you might get in contact
with James who works on the console layer to properly integrate them.