All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Andrew Clausen <clausen@melbourne.sgi.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>, mg@sgi.com, gnb@sgi.com
Subject: Re: [patch] ip27's _flush_cache_all uninitialized
Date: Fri, 14 Feb 2003 02:58:35 +0100	[thread overview]
Message-ID: <20030214025835.A5760@linux-mips.org> (raw)
In-Reply-To: <20030213060017.GL8408@pureza.melbourne.sgi.com>; from clausen@melbourne.sgi.com on Thu, Feb 13, 2003 at 05:00:17PM +1100

On Thu, Feb 13, 2003 at 05:00:17PM +1100, Andrew Clausen wrote:

> _flush_cache_all() and ___flush_cache_all() were uninitialized
> (i.e. NULL).  Someone probably assumed (incorrectly) that this
> was ok, since flush_cache_all() doesn't use _flush_cache_all()
> (or so they thought...).
> 
> End result: anything that called flush_cache_all() (a macro)
> tried to call a function at 0x0, and died.  This includes vmalloc().
> 
> I'm not sure what the best solution is, but this makes things work:

And is guaranateed to crawl.  flush_cache_all() is a no-op for the R10k.

  Ralf

  reply	other threads:[~2003-02-14  1:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-13  6:00 [patch] ip27's _flush_cache_all uninitialized Andrew Clausen
2003-02-14  1:58 ` Ralf Baechle [this message]
2003-02-14  2:21   ` Andrew Clausen
2003-02-14  2:36     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030214025835.A5760@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=clausen@melbourne.sgi.com \
    --cc=gnb@sgi.com \
    --cc=linux-mips@linux-mips.org \
    --cc=mg@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.