From: Dave Jones <davej@codemonkey.org.uk>
To: Thomas Schlichter <schlicht@uni-mannheim.de>
Cc: Andrew Morton <akpm@digeo.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()
Date: Thu, 20 Feb 2003 20:50:17 +0000 [thread overview]
Message-ID: <20030220205017.GA29206@codemonkey.org.uk> (raw)
In-Reply-To: <200302202131.08663.schlicht@uni-mannheim.de>
On Thu, Feb 20, 2003 at 09:30:55PM +0100, Thomas Schlichter wrote:
> > This looks bogus. You're killing the wbinvd() in flush_kernel_map() which
> > is needed.
> I must admit I don't exactly know the wbinvd() command, but as the comment
> says:
> /* Could use CLFLUSH here if the CPU supports it (Hammer,P4) */
>
> I thought it is not NEEDED, just a COULD...
Its hinting at a possible optimisation, not saying
that it is unneeded.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2003-02-20 20:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-20 20:00 [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all() Thomas Schlichter
2003-02-20 20:20 ` Andrew Morton
2003-02-20 20:36 ` Dave Jones
2003-02-20 20:30 ` Thomas Schlichter
2003-02-20 20:50 ` Dave Jones [this message]
2003-02-21 11:24 ` Thomas Schlichter
2003-02-21 12:19 ` [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c w ith flush_tlb_all() Hugh Dickins
2003-02-21 12:42 ` Thomas Schlichter
2003-02-21 14:20 ` Dave Jones
2003-02-21 14:25 ` Thomas Schlichter
2003-02-21 15:01 ` Dave Jones
2003-02-21 14:52 ` Hugh Dickins
2003-02-21 15:10 ` Dave Jones
2003-02-21 17:36 ` Dave Jones
2003-02-22 3:23 ` [PATCH][2.5] fix preempt-issues with smp_call_function() Thomas Schlichter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030220205017.GA29206@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schlicht@uni-mannheim.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.