From: Mitchell Blank Jr <mitch@sfgoth.com>
To: "David S. Miller" <davem@redhat.com>
Cc: chas@locutus.cmf.nrl.navy.mil, linux-kernel@vger.kernel.org
Subject: Re: [ATM] who 'owns' the skb created by drivers/atm?
Date: Thu, 20 Feb 2003 22:24:04 -0800 [thread overview]
Message-ID: <20030220222404.B11525@sfgoth.com> (raw)
In-Reply-To: <20030220.220035.64239800.davem@redhat.com>; from davem@redhat.com on Thu, Feb 20, 2003 at 10:00:35PM -0800
David S. Miller wrote:
> Some people seem to be suggesting that we need to zero
> out ->cb before passing the SKB to netif_rx() but I don't see why
> that would be neccesary.
>
> It is true, the whole input mechanism depends upon skb->cb[] being
> clear on new skbs coming in via netif_rx().
Hmmmm.. I guess we've just been getting lucky before in that case - we've
always just left the ATM_SKB() stuff in there.
Chas - I guess you should just do a memset(skb->cb, 0, sizeof(skb->cb))
just before the netif_rx() in {clip,lec,mpc}.c and before the ppp_input()
in pppoatm.c to make sure it's zeroed correctly.
-Mitch
next prev parent reply other threads:[~2003-02-21 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-21 1:18 [ATM] who 'owns' the skb created by drivers/atm? chas williams
2003-02-21 1:42 ` James Morris
2003-02-21 6:22 ` David S. Miller
2003-02-21 6:12 ` Mitchell Blank Jr
2003-02-21 6:00 ` David S. Miller
2003-02-21 6:24 ` Mitchell Blank Jr [this message]
2003-02-21 16:08 ` chas williams
2003-02-23 3:15 ` Werner Almesberger
2003-02-24 1:55 ` chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030220222404.B11525@sfgoth.com \
--to=mitch@sfgoth.com \
--cc=chas@locutus.cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.