All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ravikiran G Thirumalai <kiran@in.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, ricklind@us.ibm.com
Subject: Re: [patch] Make diskstats per-cpu using kmalloc_percpu
Date: Tue, 25 Feb 2003 14:59:45 +0530	[thread overview]
Message-ID: <20030225092945.GC28052@in.ibm.com> (raw)
In-Reply-To: <20030224235610.67e38b34.akpm@digeo.com>

On Mon, Feb 24, 2003 at 11:56:10PM -0800, Andrew Morton wrote:
> Ravikiran G Thirumalai <kiran@in.ibm.com> wrote:
> >
> > This version makes the disk stats on struct gendisk per-cpu.
> 
> Well OK, but it has lots of SCARY UPPER-CASE MACROS and disk_stat_inc(),
> disk_stat_dec() and disk_stat_sub() can all be defined in terms of
> disk_stat_add().
> 
> I did this to it:
> 

Ok, I don't have a preference one way or the other.  I used upper case 
since mib stats used upper case macros (it was that way before I 
twiddled with it).
I'll use lower case macros for the per partition stats too.

Thanks,
Kiran

  reply	other threads:[~2003-02-25  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-25  7:36 [patch] Make diskstats per-cpu using kmalloc_percpu Ravikiran G Thirumalai
2003-02-25  7:56 ` Andrew Morton
2003-02-25  9:29   ` Ravikiran G Thirumalai [this message]
2003-02-25  8:28 ` Rick Lindsley
2003-02-25  9:39   ` Ravikiran G Thirumalai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030225092945.GC28052@in.ibm.com \
    --to=kiran@in.ibm.com \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricklind@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.