From: Jens Axboe <axboe@suse.de>
To: tim@physik3.uni-rostock.de, akpm@digeo.com
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: 2.5.64 and jiffies wrap
Date: Fri, 7 Mar 2003 14:05:04 +0100 [thread overview]
Message-ID: <20030307130504.GA903@suse.de> (raw)
Hi,
The patch doesn't look right, why is INITIAL_JIFFIES being cast to
unsigned int? This breaks x86_64 at least.
--- /opt/kernel/linux-2.5.64/arch/x86_64/kernel/time.c 2003-03-07 13:54:40.000000000 +0100
+++ linux-2.5.64/arch/x86_64/kernel/time.c 2003-03-07 13:17:58.000000000 +0100
@@ -30,7 +30,7 @@
#include <asm/apic.h>
#endif
-u64 jiffies_64;
+u64 jiffies_64 = INITIAL_JIFFIES;
extern int using_apic_timer;
--- /opt/kernel/linux-2.5.64/include/linux/time.h 2003-03-07 13:54:41.000000000 +0100
+++ linux-2.5.64/include/linux/time.h 2003-03-07 13:18:10.000000000 +0100
@@ -31,7 +31,7 @@
* Have the 32 bit jiffies value wrap 5 minutes after boot
* so jiffies wrap bugs show up earlier.
*/
-#define INITIAL_JIFFIES ((unsigned int) (-300*HZ))
+#define INITIAL_JIFFIES ((unsigned long) (-300*HZ))
/*
* Change timeval to jiffies, trying to avoid the
--
Jens Axboe
next reply other threads:[~2003-03-07 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-07 13:05 Jens Axboe [this message]
2003-03-07 12:15 ` 2.5.64 and jiffies wrap Andrew Morton
2003-03-07 13:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030307130504.GA903@suse.de \
--to=axboe@suse.de \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@physik3.uni-rostock.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.