From: Oleg Drokin <green@namesys.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.5] memleak in load_elf_binary?
Date: Fri, 7 Mar 2003 14:36:07 +0300 [thread overview]
Message-ID: <20030307143607.E7347@namesys.com> (raw)
In-Reply-To: <20030307032532.17d37207.akpm@digeo.com>
Hello!
On Fri, Mar 07, 2003 at 03:25:32AM -0800, Andrew Morton wrote:
> > I am still playing with improving memleak detector thing from smatch project.
> > Seems there is a memleak in fs/binfmt_elf.c::load_elf_binary() in current 2.5
> > If setup_arg_pages() fails (line 638 in my sources) we do return but
> > not freeing possibly allocated elf_interpreter (line 520) and
> > allocated elf_phdata (line 500) areas.
> > Is this looking real? At least it looks real for me (I am trying to get
> > number of false positives way down).
> Yes, you're right. And there's a second one further down.
Ah, hm? Can you be mo precise? I do not see it.
Next return I see is in line 745, and the memory is freed before it.
Bye,
Oleg
next prev parent reply other threads:[~2003-03-07 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-07 11:12 [2.5] memleak in load_elf_binary? Oleg Drokin
2003-03-07 11:25 ` Andrew Morton
2003-03-07 11:36 ` Oleg Drokin [this message]
2003-03-07 11:51 ` Andrew Morton
2003-03-07 11:36 ` Andrew Morton
2003-03-07 20:46 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030307143607.E7347@namesys.com \
--to=green@namesys.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.