All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Oliver Neukum <oliver@neukum.name>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
	Patrick Mochel <mochel@osdl.org>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Jeff Garzik <jgarzik@pobox.com>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: PCI driver module unload race?
Date: Mon, 10 Mar 2003 15:51:31 -0800	[thread overview]
Message-ID: <20030310235131.GF13145@kroah.com> (raw)
In-Reply-To: <200303110048.43514.oliver@neukum.name>

On Tue, Mar 11, 2003 at 12:48:43AM +0100, Oliver Neukum wrote:
> 
> > diff -Nru a/drivers/base/bus.c b/drivers/base/bus.c
> > --- a/drivers/base/bus.c	Mon Mar 10 13:52:15 2003
> > +++ b/drivers/base/bus.c	Mon Mar 10 13:52:15 2003
> > @@ -263,14 +263,25 @@
> >  	if (dev->bus->match(dev,drv)) {
> >  		dev->driver = drv;
> >  		if (drv->probe) {
> > -			if ((error = drv->probe(dev))) {
> 
> It seems that the semaphore in bus_add_device() makes this unnecessary.

Hm, yes.  I think you are correct.

So this patch is not needed, and the struct module * can be ripped out
of struct usb_driver too :)

Thanks,

greg k-h

  reply	other threads:[~2003-03-10 23:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-08 10:47 PCI driver module unload race? Russell King
2003-03-08 19:12 ` Greg KH
2003-03-08 19:47   ` Petr Vandrovec
2003-03-08 19:51     ` Greg KH
2003-03-09  2:33       ` Petr Vandrovec
2003-03-08 20:03     ` Russell King
2003-03-08 20:09   ` Russell King
2003-03-08 20:21     ` Greg KH
2003-03-10 21:44       ` Greg KH
2003-03-10 23:48         ` Oliver Neukum
2003-03-10 23:51           ` Greg KH [this message]
2003-03-11  1:04             ` Roman Zippel
2003-03-11  1:15               ` Greg KH
2003-03-11  9:00                 ` Oliver Neukum
2003-03-11 15:06                   ` Patrick Mochel
2003-03-11 16:07                     ` Oliver Neukum
2003-03-16 13:13                       ` Rusty Russell
2003-03-11 11:05                 ` Roman Zippel
2003-03-11 15:27                   ` Patrick Mochel
2003-03-11 20:09                     ` Roman Zippel
2003-03-11 19:15                       ` Patrick Mochel
2003-03-12  2:28                         ` Roman Zippel
2003-03-16 13:05                     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030310235131.GF13145@kroah.com \
    --to=greg@kroah.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=oliver@neukum.name \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.