From: Oleg Drokin <green@namesys.com>
To: neilb@cse.unsw.edu.au, torvalds@transmeta.com,
linux-kernel@vger.kernel.org
Subject: [2.5] nfsd/export.c memleak.
Date: Tue, 11 Mar 2003 17:58:48 +0300 [thread overview]
Message-ID: <20030311175848.A3142@namesys.com> (raw)
Hello!
There is trivial memleak on error exit path in nfsd.
See the patch below.
Found with help of smatch + enhanced unfree script.
Bye,
Oleg
===== fs/nfsd/export.c 1.71 vs edited =====
--- 1.71/fs/nfsd/export.c Tue Feb 25 13:08:50 2003
+++ edited/fs/nfsd/export.c Tue Mar 11 17:55:18 2003
@@ -294,7 +294,10 @@
/* client */
len = qword_get(&mesg, buf, PAGE_SIZE);
- if (len <= 0) return -EINVAL;
+ if (len <= 0) {
+ err = -EINVAL;
+ goto out;
+ }
err = -ENOENT;
dom = auth_domain_find(buf);
if (!dom)
next reply other threads:[~2003-03-11 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-11 14:58 Oleg Drokin [this message]
2003-03-11 22:06 ` [2.5] nfsd/export.c memleak Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030311175848.A3142@namesys.com \
--to=green@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.