From: Gerd Knorr <kraxel@bytesex.org>
To: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@transmeta.com>,
Michael Hunold <m.hunold@gmx.de>,
Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] v4l: create include/media.
Date: Tue, 11 Mar 2003 19:12:40 +0100 [thread overview]
Message-ID: <20030311181240.GB7186@bytesex.org> (raw)
In-Reply-To: <20030310220233.A13923@infradead.org>
On Mon, Mar 10, 2003 at 10:02:33PM +0000, Christoph Hellwig wrote:
> > +#define MIN(a,b) (((a)>(b))?(b):(a))
> > +#define MAX(a,b) (((a)>(b))?(a):(b))
>
> Don't do that. Use the kernel's min/max instead.
Yea, I've noticed that too while reviewing the patch, deleted them
(and fixed the code which uses them). But then somehow managed to
mail the old patch version :-/ I'll resort stuff and mail a new
patch later today or tomorrow.
Gerd
--
/join #zonenkinder
next prev parent reply other threads:[~2003-03-11 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-10 20:08 [patch] v4l: create include/media Gerd Knorr
2003-03-10 22:02 ` Christoph Hellwig
2003-03-11 18:12 ` Gerd Knorr [this message]
2003-03-12 15:19 ` [patch] v4l: crunch MIN/MAX macros Gerd Knorr
2003-03-12 15:22 ` [patch] v4l: create include/media Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030311181240.GB7186@bytesex.org \
--to=kraxel@bytesex.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.hunold@gmx.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.