From: Oleg Drokin <green@linuxhacker.ru>
To: alan@redhat.com, linux-kernel@vger.kernel.org, greg@kroah.com,
david-b@pacbell.net
Subject: [2.4] Memleak in drivers/usb/hub.c::usb_reset_device
Date: Wed, 12 Mar 2003 22:41:33 +0300 [thread overview]
Message-ID: <20030312194133.GA27968@linuxhacker.ru> (raw)
Hello!
There seems to be a memleak in drivers/usb/hub.c::usb_reset_device()
on error exit path. See the patch.
Found with help of smatch + enhanced unfree script.
Bye,
Oleg
===== drivers/usb/hub.c 1.19 vs edited =====
--- 1.19/drivers/usb/hub.c Sat Sep 21 00:12:53 2002
+++ edited/drivers/usb/hub.c Wed Mar 12 22:38:43 2003
@@ -1057,8 +1057,10 @@
}
ret = usb_get_descriptor(dev, USB_DT_DEVICE, 0, descriptor,
sizeof(*descriptor));
- if (ret < 0)
+ if (ret < 0) {
+ kfree(descriptor);
return ret;
+ }
le16_to_cpus(&descriptor->bcdUSB);
le16_to_cpus(&descriptor->idVendor);
next reply other threads:[~2003-03-12 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-12 19:41 Oleg Drokin [this message]
2003-03-12 20:00 ` [2.4] Memleak in drivers/usb/hub.c::usb_reset_device David Brownell
2003-03-14 19:37 ` Greg KH
2003-03-14 20:02 ` Oleg Drokin
2003-03-19 23:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030312194133.GA27968@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=alan@redhat.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.