All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Drokin <green@namesys.com>
To: Oleg Drokin <green@linuxhacker.ru>,
	alan@redhat.com, linux-kernel@vger.kernel.org, viro@math.psu.edu
Subject: Re: [2.4] init/do_mounts.c::rd_load_image() memleak
Date: Fri, 14 Mar 2003 10:50:32 +0300	[thread overview]
Message-ID: <20030314105032.A17568@namesys.com> (raw)
In-Reply-To: <20030313220308.A28040@flint.arm.linux.org.uk>

Hello!

On Thu, Mar 13, 2003 at 10:03:08PM +0000, Russell King wrote:

> > +	if (buf)
> > +		kfree(buf);
> kfree(NULL); is valid - you don't need this check.

Almost every place I can think of does just this, so I do not see why this
particular piece of code should be different.

Bye,
    Oleg

  reply	other threads:[~2003-03-14  7:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-13 21:01 [2.4] init/do_mounts.c::rd_load_image() memleak Oleg Drokin
2003-03-13 22:03 ` Russell King
2003-03-14  7:50   ` Oleg Drokin [this message]
2003-03-14  7:59     ` Jens Axboe
2003-03-14  8:04       ` Oleg Drokin
2003-03-14  8:08         ` Zwane Mwaikambo
2003-03-14  8:09         ` Jens Axboe
2003-03-14 10:05           ` Denis Vlasenko
2003-03-14 17:40             ` John Alvord
2003-03-15 18:40           ` Horst von Brand
2003-03-15 18:36     ` Horst von Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030314105032.A17568@namesys.com \
    --to=green@namesys.com \
    --cc=alan@redhat.com \
    --cc=green@linuxhacker.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.