From: Andrew Morton <akpm@digeo.com>
To: bzzz@tmi.comex.ru, linux-kernel@vger.kernel.org,
ext2-devel@lists.sourceforge.net
Subject: Re: [PATCH] remove BKL from ext2's readdir
Date: Sat, 15 Mar 2003 03:03:22 -0800 [thread overview]
Message-ID: <20030315030322.792fa598.akpm@digeo.com> (raw)
In-Reply-To: <20030315023614.3e28e67b.akpm@digeo.com>
Andrew Morton <akpm@digeo.com> wrote:
>
> Alex Tomas <bzzz@tmi.comex.ru> wrote:
> >
> >
> > hi!
> >
> > I took a look at readdir() in 2.5.64's ext2 and found it serialized by BKL.
>
> Yes, I had this in -mm for ages, seem to have lost it. Also removal of BKL
> from lseek().
>
> The theory is that the lock is there to avoid f_pos races against lseek. We
> ended up deciding that the way to address this is to ensure that all readdir
> implementations do:
>
hm, no. lseek is using the directory's i_sem now, and readdir runs
under that too. So we should be able to remove lock_kernel() from
the readdir implementation of all filesystems which are using
generic_file_llseek().
next prev parent reply other threads:[~2003-03-15 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-15 10:13 [PATCH] remove BKL from ext2's readdir Alex Tomas
2003-03-15 10:36 ` Andrew Morton
2003-03-15 11:03 ` Andrew Morton [this message]
2003-03-15 16:22 ` Alex Tomas
2003-03-15 20:11 ` Andrew Morton
2003-03-15 20:09 ` Alex Tomas
2003-03-15 20:24 ` Andrew Morton
2003-03-15 20:19 ` Alex Tomas
2003-03-15 16:31 ` Robert Love
[not found] <m3vfyluedb.fsf@lexa.home.net.suse.lists.linux.kernel>
[not found] ` <20030315023614.3e28e67b.akpm@digeo.com.suse.lists.linux.kernel>
2003-03-15 21:55 ` Andi Kleen
2003-03-15 22:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030315030322.792fa598.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=bzzz@tmi.comex.ru \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.