From: Jeff Garzik <jgarzik@pobox.com>
To: Andries.Brouwer@cwi.nl
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dev_t [1/3]
Date: Tue, 18 Mar 2003 17:29:18 -0500 [thread overview]
Message-ID: <20030318222918.GD23134@gtf.org> (raw)
In-Reply-To: <UTC200303182145.h2ILjEB29313.aeb@smtp.cwi.nl>
On Tue, Mar 18, 2003 at 10:45:14PM +0100, Andries.Brouwer@cwi.nl wrote:
> The first patch is the cdev-kill patch that I sent out
> earlier. It is no use having two forms of chardev registration
> in the source, and my version of the path of small modifications
> does not pass through this version, although the final result
> will not be that different. So, kill cdev_cachep, cdev_cache_init,
> cdfind, cdget, cdput, inode->i_cdev, struct char_device.
> All of this is dead code today.
You're also removing refcount code... why not fix it up instead?
I agree your patch is mostly correct from a "today" standpoint, but from
a long term standpoint I think fixing up the code as intended would be
the best path. It would be silly to remove this code only to add it
again.
Jeff
next prev parent reply other threads:[~2003-03-18 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-18 21:45 [PATCH] dev_t [1/3] Andries.Brouwer
2003-03-18 22:29 ` Jeff Garzik [this message]
2003-03-19 22:01 ` Greg KH
2003-03-19 22:28 ` Roman Zippel
-- strict thread matches above, loose matches on Subject: below --
2003-03-18 23:53 Andries.Brouwer
2003-03-19 0:09 ` Andrew Morton
2003-03-19 0:25 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030318222918.GD23134@gtf.org \
--to=jgarzik@pobox.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.