From: Adrian Bunk <bunk@fs.tum.de>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch] 2.5.65-mjb1: lkcd: fix dump_fmt.c for !CONFIG_SMP
Date: Wed, 19 Mar 2003 09:30:25 +0100 [thread overview]
Message-ID: <20030319083025.GA23258@fs.tum.de> (raw)
In-Reply-To: <8230000.1047975763@[10.10.2.4]>
On Tue, Mar 18, 2003 at 12:22:43AM -0800, Martin J. Bligh wrote:
>...
> lkcd LKCD team
> Linux kernel crash dump support
>...
I got the following compile error for !CONFIG_SMP:
<-- snip -->
...
gcc-2.95 -Wp,-MD,drivers/dump/.dump_fmt.o.d -D__KERNEL__ -Iinclude
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc
-iwithprefix include -DKBUILD_BASENAME=dump_fmt -DKBUILD_MODNAME=dump
-c -o drivers/dump/dump_fmt.o drivers/dump/dump_fmt.c
drivers/dump/dump_fmt.c:171: macro `__dump_save_other_cpus' used without args
make[2]: *** [drivers/dump/dump_fmt.o] Error 1
<-- snip -->
Trivial fix:
--- linux-2.5.65-mjb1/include/linux/dump.h~ 2003-03-18 17:09:59.000000000 +0100
+++ linux-2.5.65-mjb1/include/linux/dump.h 2003-03-19 09:24:43.000000000 +0100
@@ -343,7 +343,7 @@
#ifdef CONFIG_SMP
extern void __dump_save_other_cpus(void);
#else
-#define __dump_save_other_cpus(void)
+#define __dump_save_other_cpus()
#endif
#endif /* __KERNEL__ */
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-03-19 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-18 8:22 2.5.65-mjb1 (scalability / NUMA patchset) Martin J. Bligh
2003-03-18 15:07 ` [Lse-tech] " Martin J. Bligh
2003-03-19 8:30 ` Adrian Bunk [this message]
2003-03-20 7:15 ` [patch] 2.5.65-mjb1: lkcd: fix dump_fmt.c for !CONFIG_SMP Martin J. Bligh
2003-03-19 8:40 ` 2.5.65-mjb1: lkcd: dump_filters.c needs asm/system.h Adrian Bunk
2003-03-19 15:33 ` [patch] 2.5.65-mjb1: lkcd: EXTRA_TARGETS is obsolete Adrian Bunk
2003-03-19 15:37 ` Christoph Hellwig
2003-03-21 20:02 ` Adrian Bunk
2003-03-19 21:17 ` Sam Ravnborg
2003-03-20 18:03 ` Matt D. Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030319083025.GA23258@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.