From: Dominik Kubla <dominik@kubla.de>
To: Christoph Hellwig <hch@infradead.org>,
Jan Dittmer <j.dittmer@portrix.net>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: i2c-via686a driver
Date: Sun, 23 Mar 2003 21:36:10 +0100 [thread overview]
Message-ID: <200303232136.10089.dominik@kubla.de> (raw)
In-Reply-To: <20030323202743.A11150@infradead.org>
Am Sonntag, 23. März 2003 21:27 schrieb Christoph Hellwig:
> // The following register sets temp interrupt mode (bits 1-0 for temp1,
> // 3-2 for temp2, 5-4 for temp3). Modes are:
> // 00 interrupt stays as long as value is out-of-range
> // 01 interrupt is cleared once register is read (default)
> // 10 comparator mode- like 00, but ignores hysteresis
> // 11 same as 00
>
> Please don't use C++-style comments in kernel code.
>
Why? It's a valid C99 feature and since the kernel already uses C99
initializers it won't compile with compilers that choke on C99 comments
anyway.
Dominik
--
Be at war with your voices, at peace with your neighbors, and let every new
year find you a better man. (Benjamin Franklin, 1706-1790)
next prev parent reply other threads:[~2003-03-23 20:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-23 19:29 i2c-via686a driver Jan Dittmer
2003-03-23 20:27 ` Christoph Hellwig
2003-03-23 20:36 ` Dominik Kubla [this message]
2003-03-23 20:48 ` Christoph Hellwig
2003-03-23 21:33 ` Jan Dittmer
2003-03-23 21:41 ` Christoph Hellwig
2003-03-23 21:38 ` Jan Dittmer
2003-03-25 3:53 ` Greg KH
2003-03-25 3:54 ` Greg KH
2003-03-25 9:12 ` Jan Dittmer
2003-03-25 17:10 ` Greg KH
2003-03-24 1:35 ` loop's kernel_thread dave young
-- strict thread matches above, loose matches on Subject: below --
2003-03-23 21:52 i2c-via686a driver Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303232136.10089.dominik@kubla.de \
--to=dominik@kubla.de \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=j.dittmer@portrix.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.