From: John Levon <levon@movementarian.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: oprofile-list@lists.sf.net, torvalds@transmeta.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Module load notification take 3
Date: Thu, 27 Mar 2003 04:17:59 +0000 [thread overview]
Message-ID: <20030327041759.GA4367@compsoc.man.ac.uk> (raw)
In-Reply-To: <20030327041148.0A4A12C054@lists.samba.org>
On Thu, Mar 27, 2003 at 01:20:23PM +1100, Rusty Russell wrote:
> What reason? I just grepped 2.5.66-bk2, and *noone* uses the return
> value, not even to BUG() (you have to grep for all the wrappers for
> notifier_call_unregister, too).
Just more grist for the mill of the ill ...
> (I assume you mean notifier_call_unregister). Yes, but that's another
> battle.
... and it's the same ill. Half-cleaned up stuff sucks. Either remove it
or don't.
> That's because everyone realizes that the return value is useless.
It detects one variant of unmatched register/unregister, so it cannot be
said to be entirely useless. I would not call it entirely useful,
though, I admit.
Beside the point though really, I appear to have made onto Linus'
shitlist at last ... does this mean I finally graduated Linux School ?
regards
john
next prev parent reply other threads:[~2003-03-27 4:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-25 2:03 [PATCH 1/2] Module load notification take 3 John Levon
2003-03-25 2:13 ` [PATCH 2/2] " John Levon
2003-03-25 6:32 ` [PATCH 1/2] " Rusty Russell
2003-03-25 11:41 ` John Levon
2003-03-27 2:20 ` Rusty Russell
2003-03-27 4:17 ` John Levon [this message]
2003-03-27 5:26 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030327041759.GA4367@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.