From: Anton Blanchard <anton@samba.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: BLKGETSIZE64 is broken (0x80041272)
Date: Fri, 28 Mar 2003 14:55:20 +1100 [thread overview]
Message-ID: <20030328035520.GD25721@krispykreme> (raw)
In-Reply-To: <20030327214214.B19517@devserv.devel.redhat.com>
> I was adding ioctl translations and found that BLKGETSIZE64
> equals 0x80041272, with wrong size. Apparently, a whole bunch
> of ioctls takes sizeof(sizeof(foo)), which evaluates to 4
> in 32 bit userland, regardless of the size of foo.
> Are we going to do anything about it? At the bare minimum,
> I suggest we add comments near EVERY of the offenders,
> marking them as broken and warning that we are leaving them
> as is for binary compatibility. I compared 2.4 and 2.5, and
> the same breakage is present in both, only more people fell
> for this trap in 2.5, so it obviously needs some action.
Thats old news :) Check out ppc64 and sparc64 ioctl32.c, its ugly but we
have to translate them.
Anton
next prev parent reply other threads:[~2003-03-28 3:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-28 2:42 BLKGETSIZE64 is broken (0x80041272) Pete Zaitcev
2003-03-28 3:55 ` Anton Blanchard [this message]
2003-03-28 7:42 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030328035520.GD25721@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.