From: Stelian Pop <stelian@popies.net>
To: "Daniel K." <dk@uw.no>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [patch] fix ec_read using wrong #define's in sonypi driver.
Date: Mon, 31 Mar 2003 16:42:15 +0200 [thread overview]
Message-ID: <20030331164215.D11090@deep-space-9.dsnet> (raw)
In-Reply-To: <3E884305.9070701@uw.no>; from dk@uw.no on Mon, Mar 31, 2003 at 01:30:45PM +0000
On Mon, Mar 31, 2003 at 01:30:45PM +0000, Daniel K. wrote:
> This patch will make the driver use the correct #define's when
> querying battery charge.
>
> This error sneaked into 2.4.20-pre1,
> and have been present in 2.5 since 2.5.49.
Damn, a copy and paste error and nobody noticed until now.
Thanks Daniel!
Linus, Marcelo, please apply it.
Stelian.
--- linux-2.4.21-pre6.vanilla/drivers/char/sonypi.c 2003-03-29 17:27:22.000000000 +0000
+++ linux-2.4.21-pre6/drivers/char/sonypi.c 2003-03-30 11:44:42.000000000 +0000
@@ -531,7 +531,7 @@
ret = -EFAULT;
break;
case SONYPI_IOCGBAT1REM:
- if (ec_read16(SONYPI_BAT1_FULL, &val16)) {
+ if (ec_read16(SONYPI_BAT1_LEFT, &val16)) {
ret = -EIO;
break;
}
@@ -539,7 +539,7 @@
ret = -EFAULT;
break;
case SONYPI_IOCGBAT2CAP:
- if (ec_read16(SONYPI_BAT1_FULL, &val16)) {
+ if (ec_read16(SONYPI_BAT2_FULL, &val16)) {
ret = -EIO;
break;
}
@@ -547,7 +547,7 @@
ret = -EFAULT;
break;
case SONYPI_IOCGBAT2REM:
- if (ec_read16(SONYPI_BAT1_FULL, &val16)) {
+ if (ec_read16(SONYPI_BAT2_LEFT, &val16)) {
ret = -EIO;
break;
}
--
Stelian Pop <stelian@popies.net>
prev parent reply other threads:[~2003-03-31 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-31 13:30 [patch] fix ec_read using wrong #define's in sonypi driver Daniel K.
2003-03-31 14:42 ` Stelian Pop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030331164215.D11090@deep-space-9.dsnet \
--to=stelian@popies.net \
--cc=dk@uw.no \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.