From: Jens Axboe <axboe@suse.de>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: "Randy.Dunlap" <rddunlap@osdl.org>,
lkml <linux-kernel@vger.kernel.org>,
arrays@hp.com, steve.cameron@hp.com
Subject: Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()
Date: Fri, 4 Apr 2003 10:09:37 +0200 [thread overview]
Message-ID: <20030404080937.GH2072@suse.de> (raw)
In-Reply-To: <20030404003044.GB16832@wohnheim.fh-wedel.de>
On Fri, Apr 04 2003, Jörn Engel wrote:
> > + error = copy_to_user(io, my_io, sizeof(*my_io)) ? -EFAULT : 0;
>
> copy_to_user returns the bytes successfully copied.
> error is set to -EFAULT, if there was actually data transferred?
>
> How about:
> + error = copy_to_user(io, my_io, sizeof(*my_io)) < sizeof(*my_io) ? -EFAULT : 0;
Pure nonsense! Correct logic, and much nicer to read IMO is:
if (copy_to_user(io, my_io, sizeof(*my_io))
error = -EFAULT;
--
Jens Axboe
next prev parent reply other threads:[~2003-04-04 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 12:03 [PATCH] reduce stack in cpqarray.c::ida_ioctl() Randy.Dunlap
2003-04-04 0:30 ` Jörn Engel
2003-04-03 17:33 ` Randy.Dunlap
2003-04-04 7:56 ` Jörn Engel
2003-04-04 8:44 ` Randy.Dunlap
2003-04-04 16:54 ` Jörn Engel
2003-04-04 8:09 ` Jens Axboe [this message]
2003-04-04 9:51 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2003-04-03 20:18 Cameron, Steve
2003-04-03 13:21 ` Randy.Dunlap
2003-04-03 21:35 Cameron, Steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030404080937.GH2072@suse.de \
--to=axboe@suse.de \
--cc=arrays@hp.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=steve.cameron@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.