All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Duncan Sands <baldrick@wanadoo.fr>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [PATCH] USB speedtouch: don't open a connection if no firmware
Date: Tue, 8 Apr 2003 13:12:40 -0700	[thread overview]
Message-ID: <20030408201239.GA5828@kroah.com> (raw)
In-Reply-To: <200304080926.43403.baldrick@wanadoo.fr>

On Tue, Apr 08, 2003 at 09:26:43AM +0200, Duncan Sands wrote:
> @@ -967,13 +969,12 @@
>  
>  	dbg ("Allocated new SARLib vcc 0x%p with vpi %d vci %d", new, vpi, vci);
>  
> -	MOD_INC_USE_COUNT;
> -
> -	if (instance->firmware_loaded)
> -		udsl_fire_receivers (instance);
> +	udsl_fire_receivers (instance);
>  
>  	dbg ("udsl_atm_open successful");
>  
> +	MOD_INC_USE_COUNT;
> +
>  	return 0;
>  }
>  

Any way you can convert this driver to not use MOD_INC_USE_COUNT, as
it's racy and not really supported anymore?  But if you _really_ have to
use it, you need to call it at the first possible chance to make any
race window smaller.

thanks,

greg k-h

  reply	other threads:[~2003-04-08 19:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-08  7:26 [PATCH] USB speedtouch: don't open a connection if no firmware Duncan Sands
2003-04-08 20:12 ` Greg KH [this message]
2003-04-08 20:22   ` [linux-usb-devel] " Duncan Sands
2003-04-08 21:40     ` Greg KH
2003-04-09  8:28       ` Duncan Sands
2003-04-09 23:31         ` Greg KH
     [not found] <OF50785981.C7D592CC-ON85256D02.007454B5-85256D02.007ACB50@wsib.on.ca>
2003-04-09  8:31 ` Duncan Sands

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030408201239.GA5828@kroah.com \
    --to=greg@kroah.com \
    --cc=baldrick@wanadoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.