All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <freesoftwaredeveloper@web.de>
To: Andreas Schwab <schwab@suse.de>
Cc: linux-kernel@vger.kernel.org, "Paweł Gołaszewski" <blues@ds.pg.gda.pl>
Subject: Re: [2.5.67] gen_rtc compile error
Date: Tue, 8 Apr 2003 21:46:07 +0200	[thread overview]
Message-ID: <200304082146.07124.freesoftwaredeveloper@web.de> (raw)
In-Reply-To: <jek7e4ixqc.fsf@sykes.suse.de>

On Tuesday 08 April 2003 21:40, Andreas Schwab wrote:
> Michael Buesch <freesoftwaredeveloper@web.de> writes:
> |> Correcting my patch: ;)
>
> Still not right.
>
> [...]
>
> Lacks a close paren if !RTC_BATT_BAD.
>
> Andreas.

Uhh, must be *very* hard to post the correct patch at first time
trying it. :)


--- drivers/char/genrtc.c.orig	2003-04-08 21:15:52.000000000 +0200
+++ drivers/char/genrtc.c	2003-04-08 21:43:37.000000000 +0200
@@ -486,16 +486,21 @@
 		     "update_IRQ\t: %s\n"
 		     "periodic_IRQ\t: %s\n"
 		     "periodic_freq\t: %ld\n"
-		     "batt_status\t: %s\n",
-		     (flags & RTC_DST_EN) ? "yes" : "no",
+#ifdef RTC_BATT_BAD
+		     "batt_status\t: %s\n"
+#endif
+		     ,(flags & RTC_DST_EN) ? "yes" : "no",
 		     (flags & RTC_DM_BINARY) ? "no" : "yes",
 		     (flags & RTC_24H) ? "yes" : "no",
 		     (flags & RTC_SQWE) ? "yes" : "no",
 		     (flags & RTC_AIE) ? "yes" : "no",
 		     irq_active ? "yes" : "no",
 		     (flags & RTC_PIE) ? "yes" : "no",
-		     0L /* freq */,
-		     (flags & RTC_BATT_BAD) ? "bad" : "okay");
+		     0L /* freq */
+#ifdef RTC_BATT_BAD
+		     ,(flags & RTC_BATT_BAD) ? "bad" : "okay"
+#endif
+		     );
 	if (!get_rtc_pll(&pll))
 	    p += sprintf(p,
 			 "PLL adjustment\t: %d\n"


  reply	other threads:[~2003-04-08 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-08 18:37 [2.5.67] gen_rtc compile error Paweł Gołaszewski
2003-04-08 19:20 ` Michael Buesch
2003-04-08 19:28   ` Paweł Gołaszewski
2003-04-08 19:30   ` Michael Buesch
2003-04-08 19:40     ` Andreas Schwab
2003-04-08 19:46       ` Michael Buesch [this message]
2003-04-08 19:48   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200304082146.07124.freesoftwaredeveloper@web.de \
    --to=freesoftwaredeveloper@web.de \
    --cc=blues@ds.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.