From: Benjamin LaHaise <bcrl@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@zip.com.au, davidm@napali.hpl.hp.com, linux-mm@kvack.org
Subject: Re: [PATCH] bootmem speedup from the IA64 tree
Date: Thu, 10 Apr 2003 09:59:30 -0400 [thread overview]
Message-ID: <20030410095930.D9136@redhat.com> (raw)
In-Reply-To: <20030410122421.A17889@lst.de>; from hch@lst.de on Thu, Apr 10, 2003 at 12:24:21PM +0200
On Thu, Apr 10, 2003 at 12:24:21PM +0200, Christoph Hellwig wrote:
> if (goal && (goal >= bdata->node_boot_start) &&
> - ((goal >> PAGE_SHIFT) < bdata->node_low_pfn)) {
> + ((goal >> PAGE_SHIFT) < bdata->node_low_pfn)) {
> preferred = goal - bdata->node_boot_start;
> +
> + if (last_success >= preferred)
> + preferred = last_success;
I suspect you need a range check on last_success here for machines which have
multiple nodes of memory, or else store it in bdata.
-ben
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2003-04-10 13:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-10 10:24 [PATCH] bootmem speedup from the IA64 tree Christoph Hellwig
2003-04-10 10:35 ` Andrew Morton
2003-04-10 14:18 ` Martin J. Bligh
2003-04-10 16:46 ` Martin J. Bligh
2003-04-10 13:59 ` Benjamin LaHaise [this message]
2003-04-10 20:43 ` Andrew Morton
2003-04-10 20:34 ` Martin J. Bligh
2003-04-10 21:07 ` Andrew Morton
2003-04-10 21:02 ` William Lee Irwin III
2003-04-11 20:32 ` Rik van Riel
2003-04-11 20:57 ` Andrew Morton
2003-04-11 21:27 ` David Mosberger
2003-04-11 20:58 ` David Mosberger
2003-04-10 15:25 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030410095930.D9136@redhat.com \
--to=bcrl@redhat.com \
--cc=akpm@zip.com.au \
--cc=davidm@napali.hpl.hp.com \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.