All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Collins <bcollins@debian.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Adrian Bunk <bunk@fs.tum.de>, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix nodemgr.c compile (was Re: 2.5.67-mm2: ieee1394/nodemgr.c doesn't compile)
Date: Sun, 13 Apr 2003 15:23:54 -0400	[thread overview]
Message-ID: <20030413192354.GD16706@phunnypharm.org> (raw)
In-Reply-To: <20030413125744.GN9640@fs.tum.de>

> The following compile error #ifdef CONFIG_IEEE1394_VERBOSEDEBUG seems to 
> come from Linus' tree:

Thanks, here's a patch.

Index: nodemgr.c
===================================================================
--- linux/drivers/ieee1394/nodemgr.c	(revision 862)
+++ linux/drivers/ieee1394/nodemgr.c	(working copy)
@@ -1010,34 +1010,7 @@
 		kfree(ud);
 }
 
-static void dump_directories (struct node_entry *ne)
-{
-#ifdef CONFIG_IEEE1394_VERBOSEDEBUG
-	struct list_head *l;
 
-	HPSB_DEBUG("vendor_id=0x%06x [%s], capabilities=0x%06x",
-		   ne->vendor_id, ne->vendor_name ?: "Unknown",
-		   ne->capabilities);
-	list_for_each (l, &ne->unit_directories) {
-		struct unit_directory *ud = list_entry (l, struct unit_directory, node_list);
-		HPSB_DEBUG("unit directory:");
-		if (ud->flags & UNIT_DIRECTORY_VENDOR_ID)
-			HPSB_DEBUG("  vendor_id=0x%06x [%s]",
-				   ud->vendor_id,
-				   ud->vendor_name ?: "Unknown");
-		if (ud->flags & UNIT_DIRECTORY_MODEL_ID)
-			HPSB_DEBUG("  model_id=0x%06x [%s]",
-				   ud->model_id,
-				   ud->model_name ?: "Unknown");
-		if (ud->flags & UNIT_DIRECTORY_SPECIFIER_ID)
-			HPSB_DEBUG("  sw_specifier_id=0x%06x ", ud->specifier_id);
-		if (ud->flags & UNIT_DIRECTORY_VERSION)
-			HPSB_DEBUG("  sw_version=0x%06x ", ud->version);
-	}
-#endif
-	return;
-}
-
 static void nodemgr_process_root_directory(struct host_info *hi, struct node_entry *ne)
 {
 	octlet_t address;
@@ -1104,8 +1077,6 @@
 			break;
 		}
 	}
-
-	dump_directories(ne);
 }
 
 #ifdef CONFIG_HOTPLUG

  reply	other threads:[~2003-04-13 19:15 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-13  1:08 2.5.67-mm2 Andrew Morton
2003-04-13  1:08 ` 2.5.67-mm2 Andrew Morton
2003-04-13  1:55 ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13  1:55   ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13  3:03   ` 2.5.67-mm2 Jeremy Hall
2003-04-13  3:03     ` 2.5.67-mm2 Jeremy Hall
2003-04-13  3:10     ` 2.5.67-mm2 Andrew Morton
2003-04-13  3:10       ` 2.5.67-mm2 Andrew Morton
2003-04-13  3:54       ` 2.5.67-mm2 Jeremy Hall
2003-04-13  3:54         ` 2.5.67-mm2 Jeremy Hall
2003-04-13  4:22         ` 2.5.67-mm2 Jeremy Hall
2003-04-13  4:22           ` 2.5.67-mm2 Jeremy Hall
2003-04-13  4:32           ` 2.5.67-mm2 Andrew Morton
2003-04-13  4:32             ` 2.5.67-mm2 Andrew Morton
2003-04-13  3:14     ` 2.5.67-mm2 William Lee Irwin III
2003-04-13  3:14       ` 2.5.67-mm2 William Lee Irwin III
2003-04-13  3:50       ` 2.5.67-mm2 Jeremy Hall
2003-04-13  3:50         ` 2.5.67-mm2 Jeremy Hall
2003-04-13  4:42         ` 2.5.67-mm2 Andrew Morton
2003-04-13  4:42           ` 2.5.67-mm2 Andrew Morton
2003-04-13  7:38           ` 2.5.67-mm2 Joshua Kwan
2003-04-13 19:02           ` 2.5.67-mm2 J Sloan
2003-04-13  3:17   ` 2.5.67-mm2 Valdis.Kletnieks
2003-04-13 11:15     ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13 11:15       ` 2.5.67-mm2 Felipe Alfaro Solana
2003-04-13  8:11   ` 2.5.67-mm2 Russell King
2003-04-13  8:11     ` 2.5.67-mm2 Russell King
2003-04-13 12:57 ` 2.5.67-mm2: ieee1394/nodemgr.c doesn't compile Adrian Bunk
2003-04-13 19:23   ` Ben Collins [this message]
2003-04-13 13:12 ` 2.5.67-mm2 Ingo Oeser
2003-04-13 13:12   ` 2.5.67-mm2 Ingo Oeser
2003-04-13 14:54   ` 2.5.67-mm2 Arjan van de Ven
2003-04-14  6:24     ` 2.5.67-mm2 Denis Vlasenko
2003-04-14  6:24       ` 2.5.67-mm2 Denis Vlasenko
2003-04-14  8:49       ` 2.5.67-mm2 Arjan van de Ven
2003-04-14  8:49         ` 2.5.67-mm2 Arjan van de Ven
2003-04-13 20:16 ` 2.5.67-mm2: multiple definition of `ipip_err' Adrian Bunk
2003-04-13 20:57   ` Andrew Morton
2003-04-13 23:34   ` David S. Miller
2003-04-14 17:48 ` 2.5.67-mm2 Joel Becker
2003-04-14 17:48   ` 2.5.67-mm2 Joel Becker
2003-04-14 21:31   ` 2.5.67-mm2 Andrew Morton
2003-04-14 21:31     ` 2.5.67-mm2 Andrew Morton
2003-04-14 21:34     ` 2.5.67-mm2 Randy.Dunlap
2003-04-14 21:34       ` 2.5.67-mm2 Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030413192354.GD16706@phunnypharm.org \
    --to=bcollins@debian.org \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.