From: Mike Anderson <andmike@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: stern@rowland.harvard.edu
Subject: [PATCH] 2.5.67+ scsi_release_request call queue next
Date: Mon, 14 Apr 2003 23:33:03 -0700 [thread overview]
Message-ID: <20030415063303.GC1366@beaverton.ibm.com> (raw)
This patch is against 2.5.67 as of 04-14 as it needs extern for
scsi_queue_next_request.
I just compiled and booted this patch. I currently do not have a setup to
check door lock post error recovery.
-andmike
--
Michael Anderson
andmike@us.ibm.com
DESC
The patch adds a call to scsi_queue_next_request from scsi_release_request. It
also removes a call in scsi_eh_lock_done to scsi_put_command.
scsi_release_request will do a call to scsi_put_command if needed.
EDESC
drivers/scsi/scsi.c | 2 ++
drivers/scsi/scsi_error.c | 4 ----
2 files changed, 2 insertions(+), 4 deletions(-)
diff -puN drivers/scsi/scsi.c~scsi-release-req drivers/scsi/scsi.c
--- sysfs-bleed-2.5/drivers/scsi/scsi.c~scsi-release-req Mon Apr 14 15:34:14 2003
+++ sysfs-bleed-2.5-andmike/drivers/scsi/scsi.c Mon Apr 14 15:34:14 2003
@@ -224,8 +224,10 @@ void scsi_release_request(Scsi_Request *
{
if( req->sr_command != NULL )
{
+ request_queue_t *q = req->sr_device->request_queue;
scsi_put_command(req->sr_command);
req->sr_command = NULL;
+ scsi_queue_next_request(q, NULL);
}
kfree(req);
diff -puN drivers/scsi/scsi_error.c~scsi-release-req drivers/scsi/scsi_error.c
--- sysfs-bleed-2.5/drivers/scsi/scsi_error.c~scsi-release-req Mon Apr 14 15:34:14 2003
+++ sysfs-bleed-2.5-andmike/drivers/scsi/scsi_error.c Mon Apr 14 15:34:14 2003
@@ -1334,10 +1334,6 @@ static void scsi_eh_lock_done(struct scs
{
struct scsi_request *sreq = scmd->sc_request;
- scmd->sc_request = NULL;
- sreq->sr_command = NULL;
-
- scsi_put_command(scmd);
scsi_release_request(sreq);
}
_
next reply other threads:[~2003-04-15 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-15 6:33 Mike Anderson [this message]
2003-04-15 15:01 ` Trivial patch for scsi logging text string Alan Stern
2003-04-15 17:03 ` Greg KH
2003-04-15 17:10 ` James Bottomley
2003-04-15 19:31 ` Alan Stern
2003-04-15 21:42 ` James Bottomley
2003-04-15 19:39 ` [PATCH] 2.5.67+ scsi_release_request call queue next Alan Stern
2003-04-15 22:36 ` Mike Anderson
-- strict thread matches above, loose matches on Subject: below --
2003-04-29 20:56 Alan Stern
2003-04-29 21:18 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030415063303.GC1366@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.