All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: "Måns Rullgård" <mru@users.sourceforge.net>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Writing modules for 2.5
Date: Tue, 15 Apr 2003 13:57:58 +0100	[thread overview]
Message-ID: <20030415135758.C32468@flint.arm.linux.org.uk> (raw)
In-Reply-To: <yw1xbrz87x59.fsf@zaphod.guide>; from mru@users.sourceforge.net on Tue, Apr 15, 2003 at 02:39:14PM +0200

On Tue, Apr 15, 2003 at 02:39:14PM +0200, Måns Rullgård wrote:
> My situation is like this: I am converting a char device driver to
> work with linux 2.5.  In the open and close functions there are
> MOD_INC/DEC_USECOUNT calls.  The question is what they should be
> replaced with.  Will it be handled correctly without them?

If it's a character device driver using the struct file_operations,
set the owner field as Alan mentioned, and remove the
MOD_{INC,DEC}_USE_COUNT macros from the open/close methods.  This
allows chrdev_open() (in fs/char_dev.c) to increment your module use
count automatically.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


  reply	other threads:[~2003-04-15 12:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <yw1x7k9w9flm.fsf@zaphod.guide.suse.lists.linux.kernel>
2003-04-15 11:28 ` Writing modules for 2.5 Andi Kleen
2003-04-15 12:00   ` Måns Rullgård
2003-04-15 12:05     ` Andi Kleen
2003-04-15 12:05   ` Måns Rullgård
2003-04-15 11:35     ` Alan Cox
2003-04-15 12:39       ` Måns Rullgård
2003-04-15 12:57         ` Russell King [this message]
2003-04-15 13:24           ` Dave Jones
2003-04-15 15:42           ` Måns Rullgård
2003-04-15 21:31             ` Russell King
2003-04-15 14:24         ` Alan Cox
2003-04-15 12:15     ` Andreas Henriksson
2003-04-15 12:30       ` Måns Rullgård
2003-04-15 12:58       ` Russell King
2003-04-15 11:15 Måns Rullgård
2003-04-15 14:24 ` Jonathan Corbet
2003-04-15 20:43 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030415135758.C32468@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mru@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.