All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Frode Isaksen <fisaksen@bewan.com>
Cc: linux-kernel@vger.kernel.org, weissg@vienna.at
Subject: Re: PATCH: usb-uhci: interrupt out with urb->interval 0
Date: Fri, 18 Apr 2003 00:05:14 -0700	[thread overview]
Message-ID: <20030418070514.GA2322@kroah.com> (raw)
In-Reply-To: <F628F73A-70AE-11D7-8F05-003065EF6010@bewan.com>

On Thu, Apr 17, 2003 at 10:31:18AM +0200, Frode Isaksen wrote:
> A recent change (2.4.21)

Um, 2.4.21 is not out yet :)

> in the usb-uhci driver calls 
> "uhci_clean_iso_step2" after the completion of one-shot (urb->interval 
> 0) interrupt out transfers. This call clears the list of descriptors. 
> However, it crashes when trying to get the next desciptor in the "for" 
> loop in the "process_interrupt" function, since the list of descriptors 
> are already cleared. A simple change I did was to do a "break" to quit 
> the "for" loop for interrupt out transfers with urb->interval 0.

Hm, I thought someone tested this previously.  Do you have a test case
for this that I can try to duplicate the problem for?

Also, your patch will not apply against the latest (2.4.21-pre7) version
of this file.

thanks,

greg k-h

p.s. I'd recommend sending these kinds of patches to the linux-usb-devel
mailing list too.  That's where most of the Linux USB developers are.

  reply	other threads:[~2003-04-18  6:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-17  8:31 PATCH: usb-uhci: interrupt out with urb->interval 0 Frode Isaksen
2003-04-18  7:05 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-04-20  8:08 David Glance
2003-04-20 13:32 ` David Glance
2003-04-17  7:20 Frode Isaksen
2003-04-16 15:44 Frode Isaksen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030418070514.GA2322@kroah.com \
    --to=greg@kroah.com \
    --cc=fisaksen@bewan.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weissg@vienna.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.