From: Alan Cox <alan@redhat.com>
To: rain.wang@mic.com.tw (rain.wang)
Cc: alan@redhat.com (Alan Cox), axboe@suse.de (Jens Axboe),
linux-kernel@vger.kernel.org
Subject: Re: Linux 2.5.67-ac2: ide reset issue
Date: Fri, 18 Apr 2003 07:46:24 -0400 (EDT) [thread overview]
Message-ID: <200304181146.h3IBkOx06987@devserv.devel.redhat.com> (raw)
In-Reply-To: <3E9F9440.7F7CBDC8@mic.com.tw> from "rain.wang" at Ebr 18, 2003 01:59:28
> I don't know if there's enough reason to change reset semantics
> now to wait for completion, so that the next call be free of race.
> and I once had a simpler fix to let it delay another 50ms, that works
> on my box but seems not a thorough one. does it help?
BWGROUP(drive)->busy should never reach zero until the reset is
done. The 50mS miught be enough that this occurs, as might waiting
for HWGROUP(drive)->busy hitting 0. I don't yet understand why it
matters, and to fix it properly I have to figure that out.
If you need reliable reset for something like a test harness, or
IDE drive tester its a usable workaround, but I need to fix it
properly (eventually)
> + /* wait for another 50ms */
> + mdelay(50);
In your test set is HWGROUP(drive)->busy always zero after the
mdelay ?
next prev parent reply other threads:[~2003-04-18 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-17 23:19 Linux 2.5.67-ac2 Alan Cox
2003-04-18 5:59 ` Linux 2.5.67-ac2: ide reset issue rain.wang
2003-04-18 11:46 ` Alan Cox [this message]
2003-04-19 7:38 ` rain.wang
2003-04-18 6:32 ` Linux 2.5.67-ac2 Rudmer van Dijk
2003-04-18 18:51 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304181146.h3IBkOx06987@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rain.wang@mic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.