From: Christoph Hellwig <hch@lst.de>
To: Roland Dreier <roland@topspin.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devfs (2/7) - minor miscdev changes
Date: Fri, 18 Apr 2003 19:03:55 +0200 [thread overview]
Message-ID: <20030418190355.A718@lst.de> (raw)
In-Reply-To: <52znmn7os3.fsf@topspin.com>; from roland@topspin.com on Fri, Apr 18, 2003 at 09:29:00AM -0700
On Fri, Apr 18, 2003 at 09:29:00AM -0700, Roland Dreier wrote:
> int misc_register(struct miscdevice * misc)
> {
> - static devfs_handle_t devfs_handle, dir;
> struct miscdevice *c;
> + char buf[256];
>
> Wouldn't it be better not to have a 256-byte buffer on the stack?
You're probably right. But 64 bytes should be enough anyway - that's
what devfs uses everywhere else.
prev parent reply other threads:[~2003-04-18 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-18 16:12 [PATCH] devfs (2/7) - minor miscdev changes Christoph Hellwig
2003-04-18 16:29 ` Roland Dreier
2003-04-18 17:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030418190355.A718@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.