From: Jens Axboe <axboe@suse.de>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andre Hedrick <andre@linux-ide.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (4/4)
Date: Thu, 24 Apr 2003 09:56:18 +0200 [thread overview]
Message-ID: <20030424075618.GC8775@suse.de> (raw)
In-Reply-To: <Pine.SOL.4.30.0304231939410.10502-100000@mion.elka.pw.edu.pl>
On Wed, Apr 23 2003, Bartlomiej Zolnierkiewicz wrote:
>
> diff -uNr linux-2.5.67-ac2-dtf3/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
> --- linux-2.5.67-ac2-dtf3/drivers/ide/ide-taskfile.c Wed Apr 23 15:44:36 2003
> +++ linux/drivers/ide/ide-taskfile.c Wed Apr 23 16:22:12 2003
> @@ -1054,6 +1054,25 @@
>
> EXPORT_SYMBOL(ide_raw_taskfile);
>
> +/*
> + * Comments to ide_diag_taskfile() apply here as well.
> + */
> +static int ide_bio_taskfile (ide_drive_t *drive, ide_task_t *args,
> + request_queue_t *q, struct bio *bio)
> +{
any reason you are passing q seperately instead of using &drive->queue?
--
Jens Axboe
next prev parent reply other threads:[~2003-04-24 7:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 17:37 [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4) Bartlomiej Zolnierkiewicz
2003-04-23 17:38 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (1/4) Bartlomiej Zolnierkiewicz
2003-04-24 8:23 ` Jens Axboe
2003-04-24 14:46 ` Bartlomiej Zolnierkiewicz
2003-04-24 15:47 ` [PATCH] 2.5.68 fix mismatched access_ok() checks in sg_io() Bartlomiej Zolnierkiewicz
2003-04-24 17:31 ` Jens Axboe
2003-04-23 17:39 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (2/4) Bartlomiej Zolnierkiewicz
2003-04-23 17:39 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (3/4) Bartlomiej Zolnierkiewicz
2003-04-23 17:40 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (4/4) Bartlomiej Zolnierkiewicz
2003-04-24 7:56 ` Jens Axboe [this message]
2003-04-23 18:24 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4) [resend] Bartlomiej Zolnierkiewicz
2003-04-23 22:35 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4) Andrew Morton
2003-04-23 22:09 ` Alan Cox
2003-04-23 22:58 ` Bartlomiej Zolnierkiewicz
2003-04-23 23:13 ` Andries Brouwer
2003-04-23 23:20 ` Andrew Morton
2003-04-24 0:02 ` Bartlomiej Zolnierkiewicz
2003-04-24 6:55 ` Jens Axboe
2003-04-24 2:27 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030424075618.GC8775@suse.de \
--to=axboe@suse.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.