From: Andrew Morton <akpm@digeo.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: daniel@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.68 2/2] i_size atomic access
Date: Fri, 25 Apr 2003 03:57:27 -0700 [thread overview]
Message-ID: <20030425035727.6f107236.akpm@digeo.com> (raw)
In-Reply-To: <20030425014208.GC26194@dualathlon.random>
Andrea Arcangeli <andrea@suse.de> wrote:
>
> On Thu, Apr 24, 2003 at 06:05:03PM -0700, Andrew Morton wrote:
> > And if the race _does_ hit, what is the effect? Assuming stat() was fixed
> > with i_sem, I don't think the race has a very serious effect. We won't
>
> writepage needs it too to avoid returning -EIO and I doubt you want to
> take the i_sem in writepage
Well the -EIO thing is bogus really, but yes. The writepage will not hit
disk *at all*. That's a problem.
We modify i_size in very few places - an alternative might be to maintain a
parallel unsigned long i_size>>PAGE_CACHE_SIZE in the inode and use that in
critical places. Sounds messy though.
Ho hum. ugh.
next prev parent reply other threads:[~2003-04-25 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-25 0:30 [PATCH 2.5.68 2/2] i_size atomic access Daniel McNeil
2003-04-25 1:05 ` Andrew Morton
2003-04-25 1:42 ` Andrea Arcangeli
2003-04-25 10:57 ` Andrew Morton [this message]
2003-04-25 23:17 ` Daniel McNeil
2003-04-30 0:40 ` Daniel McNeil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030425035727.6f107236.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=andrea@suse.de \
--cc=daniel@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.