Re: [RFC/PATCH] IDE Power Management try 1

[Jens Axboe <axboe@suse.de>]

On Fri, Apr 25 2003, Benjamin Herrenschmidt wrote:
> 
> > 		What about this - add __REQ_DRIVE_INTERNAL, and carry args in 
> > rq->cmd[16] [0] = PM, [1] = SUSPEND/RESUME, [2]= STATE ? IDE can use it 
> > for power managment, error handling (do not do it from interrupt 
> > context, but queue it), may be more. This way it would really makes 
> > things a bit better with the complicated IDE locking. SCSI and probably 
> > other block devices can benefit from this internal requests too, so the 
> > bit is not wasted.
> 
> I agree. IDE locking isn't _that_ complicated ;) Though currently, we do

>From the request side of things, IDE is very simple.

> handle requests right on interrupt completion so error handling wouldn't
> be deferred by this trick.
> 
> Jens, what do you think ? You are the blkdev.h guy :)

If you add REQ_DRIVE_INTERNAL, and kill the other ones I mentioned, fine
with me then.

	rq->flags & REQ_DRIVE_INTERNAL
		rq->cmd[0] == PM
			pm stuf
		rq->cmd[0] = taskfile
			taskfile

etc. Make sense?

-- 
Jens Axboe