From: David Gibson <hermes@gibson.dropbear.id.au>
To: Christoph Hellwig <hch@infradead.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-kernel@vger.kernel.org, Jean Tourrilhes <jt@hpl.hp.com>,
David Hinds <dhinds@sonic.net>
Subject: Re: Update to orinoco driver (2.4)
Date: Sat, 26 Apr 2003 10:30:18 +1000 [thread overview]
Message-ID: <20030426003018.GA14509@zax> (raw)
In-Reply-To: <20030425153706.A2024@infradead.org>
On Fri, Apr 25, 2003 at 03:37:06PM +0100, Christoph Hellwig wrote:
> > +static void __exit exit_hermes(void)
> > +{
> > +}
> > +
> > module_init(init_hermes);
> > +module_exit(exit_hermes);
>
> Please don't add exmpty functions without a reak good reason.
And the real good reason would be that the module can't be unloaded
without an exit function.
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2003-04-26 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 5:46 Update to orinoco driver (2.4) David Gibson
2003-04-23 6:05 ` David Gibson
2003-04-25 12:10 ` Benjamin Herrenschmidt
2003-04-25 12:53 ` David Gibson
2003-04-25 14:23 ` Jens Axboe
2003-04-25 14:37 ` Christoph Hellwig
2003-04-26 0:30 ` David Gibson [this message]
2003-04-26 5:22 ` Christoph Hellwig
2003-04-26 6:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030426003018.GA14509@zax \
--to=hermes@gibson.dropbear.id.au \
--cc=dhinds@sonic.net \
--cc=hch@infradead.org \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.