From: "David S. Miller" <davem@redhat.com>
To: acme@conectiva.com.br
Cc: mostrows@speakeasy.net, netdev@oss.sgi.com, maxk@qualcomm.com
Subject: Re: [PATCH] af_pppox: create module infrastructure for protocol modules
Date: Mon, 28 Apr 2003 23:00:34 -0700 (PDT) [thread overview]
Message-ID: <20030428.230034.08345606.davem@redhat.com> (raw)
In-Reply-To: <20030429065419.GN25361@conectiva.com.br>
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Date: Tue, 29 Apr 2003 03:54:19 -0300
Em Mon, Apr 28, 2003 at 10:27:28PM -0700, David S. Miller escreveu:
> Although the idea is conceptually sound, you miss one crucial thing.
> Such struct sock's reference _TWO_ modules, the "PPPOE" module
> and the "PPPOX" module.
But what is the problem? at pppox_sk_alloc time I bump the PPPOE
module refcnt, making it safe, then it calls sk_alloc where it
bumps the PPPOX module, making it safe as well, so I'm taking care
of both PPPOE and PPPOX.
You're absolutely correct, I missed this.
I'll pull your changes, thanks.
next prev parent reply other threads:[~2003-04-29 6:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-29 6:12 [PATCH] af_pppox: create module infrastructure for protocol modules Arnaldo Carvalho de Melo
2003-04-29 5:27 ` David S. Miller
2003-04-29 6:46 ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-29 6:00 ` David S. Miller
2003-04-29 7:12 ` Arnaldo Carvalho de Melo
2003-04-29 6:54 ` Arnaldo Carvalho de Melo
2003-04-29 6:00 ` David S. Miller [this message]
2003-04-29 20:05 ` Max Krasnyansky
2003-04-29 22:07 ` Arnaldo Carvalho de Melo
2003-04-30 0:43 ` Max Krasnyansky
2003-04-30 2:29 ` David S. Miller
2003-04-30 18:11 ` Max Krasnyansky
2003-05-01 9:20 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030428.230034.08345606.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=maxk@qualcomm.com \
--cc=mostrows@speakeasy.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.