[PATCH]: asm-mips/sgi/mc.h register padding broken

[PATCH]: asm-mips/sgi/mc.h register padding broken

[Guido Guenther]

Hi Ralf,
the register layout of the IP22s mc is missing some paddings which
results in some nice bus error exceptions. Please apply this patch
against 2.4. and 2.5:

diff -u -p -r1.1.2.1 mc.h
--- include/asm-mips/sgi/mc.h	19 Mar 2003 04:23:22 -0000	1.1.2.1
+++ include/asm-mips/sgi/mc.h	27 Apr 2003 14:41:36 -0000
@@ -153,7 +153,7 @@ struct sgimc_regs {
 	volatile u32 elock;		/* Locks EISA from GIO accesses */
 
 	/* GIO dma control registers. */
-	u32 _unused22[14];
+	u32 _unused22[15];
 	volatile u32 gio_dma_trans;	/* DMA mask to translation GIO addrs */
 	u32 _unused23;
 	volatile u32 gio_dma_sbits;	/* DMA GIO addr substitution bits */
@@ -163,7 +163,7 @@ struct sgimc_regs {
 	volatile u32 dma_ctrl;		/* Main DMA control reg */
 
 	/* DMA TLB entry 0 */
-	u32 _unused26;
+	u32 _unused26[5];
 	volatile u32 dtlb_hi0;
 	u32 _unused27;
 	volatile u32 dtlb_lo0;

Regards,
 -- Guido

Re: [PATCH]: asm-mips/sgi/mc.h register padding broken

[Ralf Baechle]

On Sun, Apr 27, 2003 at 04:47:30PM +0200, Guido Guenther wrote:

> the register layout of the IP22s mc is missing some paddings which
> results in some nice bus error exceptions. Please apply this patch
> against 2.4. and 2.5:

Applied,

  Ralf