From: Dipankar Sarma <dipankar@in.ibm.com>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reducing overheads in fget/fput
Date: Tue, 29 Apr 2003 01:28:36 +0530 [thread overview]
Message-ID: <20030428195836.GD1105@in.ibm.com> (raw)
In-Reply-To: <20030428193228.GP10374@parcelfarce.linux.theplanet.co.uk>
On Mon, Apr 28, 2003 at 08:32:28PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> You are. Have a process share file table at the time of call and
> have its sibling die in the middle. Oops - condition that had
> been true at time of fget_light() (->files->count > 1) is false
> at the time we fput_light(). Have fun - we had just leaked a
> reference to struct file.
That shouldn't be very difficult to fix. For the fget_light/fput_light
pair in a syscall, we make the files->count == 1 check only once at the
beginning. Do you see a problem with that ?
Thanks
Dipankar
next prev parent reply other threads:[~2003-04-28 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-28 16:52 [PATCH] reducing overheads in fget/fput Dipankar Sarma
2003-04-28 19:32 ` viro
2003-04-28 19:58 ` Dipankar Sarma [this message]
2003-05-02 17:17 ` Dipankar Sarma
2003-05-02 20:54 ` Andrew Morton
2003-05-03 3:53 ` Dipankar Sarma
2003-05-03 4:00 ` Andrew Morton
2003-05-03 4:24 ` Dipankar Sarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030428195836.GD1105@in.ibm.com \
--to=dipankar@in.ibm.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.