From: viro@parcelfarce.linux.theplanet.co.uk
To: Gabriel Devenyi <devenyga@mcmaster.ca>
Cc: alan@redhat.com, torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68
Date: Tue, 29 Apr 2003 23:42:28 +0100 [thread overview]
Message-ID: <20030429224228.GQ10374@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200304292215.20590.devenyga@mcmaster.ca>
On Tue, Apr 29, 2003 at 10:15:20PM +0000, Gabriel Devenyi wrote:
> This patch applies to 2.5.68. It converts all the remaining error returns to
> the new return -E form, this is in the KernelJanitor TODO list.
>
> http://muss.mcmaster.ca/~devenyga/patch-linux-2.5.68-return-errors.patch
>
> Please CC me with any discussion since I do not subscribe to lkml
Have you tried to compile the patched kernel?
Patch is bogus - most of the changes are s/return ERR_PTR(foo)/return foo/
with neither explanation nor change of function prototype not change of
other exits from these functions.
WTF was it intended to do?
next prev parent reply other threads:[~2003-04-29 22:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-29 22:15 [PATCH] KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68 Gabriel Devenyi
2003-04-29 22:32 ` Randy.Dunlap
2003-04-29 23:08 ` Gabriel Devenyi
2003-04-30 0:22 ` Dave Jones
2003-04-29 22:42 ` viro [this message]
2003-04-29 23:11 ` Gabriel Devenyi
2003-05-05 22:11 ` Pavel Machek
2003-05-05 22:22 ` viro
2003-05-05 22:33 ` Martin Mares
-- strict thread matches above, loose matches on Subject: below --
2003-04-29 23:11 Randy.Dunlap
2003-04-30 0:02 ` viro
2003-04-30 0:25 ` John Levon
2003-04-30 14:19 ` Dave Kleikamp
2003-05-01 4:12 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030429224228.GQ10374@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=alan@redhat.com \
--cc=devenyga@mcmaster.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.