All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Ben Collins <bcollins@debian.org>
Cc: torvalds@transmeta.com, pavel@ucw.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix NULL handler for compat_ioctl
Date: Wed, 30 Apr 2003 20:40:46 -0700	[thread overview]
Message-ID: <20030430204046.13fffc7d.akpm@digeo.com> (raw)
In-Reply-To: <20030501025955.GA622@phunnypharm.org>

Ben Collins <bcollins@debian.org> wrote:
>
> > - sys_ioctl takes three args, but this vector is going to be called with
> >   four.  That's making assumptions about arg passing conventions which may
> >   not be true.
> > 
> > - sys_ioctl() is asmlinkage, but the caller of this vector doesn't know
> >   that.  Arguments may get put in the wrong place.
> 
> Out of all the register_ioctl32_conversion functions that were
> consolidated with this patch, only s390 and x86_64 did not already use
> this same convention. linux/ioctl32.h already documents (and has always
> been that way) this feature.

Yup. I'm not surprised that it works.  But ick.

> Maybe you feel better about this patch instead?

Infinitely ;)



      reply	other threads:[~2003-05-01  3:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-01  1:34 [PATCH] Fix NULL handler for compat_ioctl Ben Collins
2003-05-01  2:41 ` Andrew Morton
2003-05-01  2:59   ` Ben Collins
2003-05-01  3:40     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030430204046.13fffc7d.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.