From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "David S. Miller" <davem@redhat.com>
Cc: Steve@ChyGwyn.com, steve@gw.chygwyn.com, hch@infradead.org,
linux-decnet-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: Remains of seq_file conversion for DECnet, plus fixes
Date: Thu, 1 May 2003 22:54:10 -0300 [thread overview]
Message-ID: <20030502015409.GC5356@conectiva.com.br> (raw)
In-Reply-To: <20030501.142235.91789378.davem@redhat.com>
Em Thu, May 01, 2003 at 02:22:35PM -0700, David S. Miller escreveu:
> From: Steven Whitehouse <steve@gw.chygwyn.com>
> Date: Thu, 1 May 2003 22:35:46 +0100 (BST)
> > The name is a bit generic for an export function. What about
> > seq_release_kfree?
> Yes, I'd considered that and eventually settled for the non-prefixed
> version since it followed the pattern set by single_release() which
> doesn't have the seq_ prefix. I don't mind changing it though if the
> prefixed version is preferred,
> I think a naming convention without a prefix is asking for
> trouble. I'd ask that you add the prefix, the current convention
> is troublesome and someone ought to clean that up.
Agreed, I also tought of adding it as a generic function, that is the spirit
of ip_seq_release, that is already used several net/ipv4 seq_file routines
and should be deleted in favour of seq_release_private, that is my preferred
name, as it is more general.
- Arnaldo
next prev parent reply other threads:[~2003-05-02 1:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030418.034241.38698733.davem@redhat.com>
2003-04-21 10:21 ` ip_gre.c:ipgre_tunnel_xmit() duplicated code ? Steven Whitehouse
2003-04-22 6:43 ` David S. Miller
2003-05-01 13:27 ` Remains of seq_file conversion for DECnet, plus fixes Steven Whitehouse
2003-05-01 12:45 ` David S. Miller
2003-05-01 14:04 ` Steven Whitehouse
2003-05-01 13:09 ` David S. Miller
2003-05-01 20:52 ` Steven Whitehouse
2003-05-01 20:57 ` Christoph Hellwig
2003-05-01 21:35 ` Steven Whitehouse
2003-05-01 21:22 ` David S. Miller
2003-05-02 1:54 ` Arnaldo Carvalho de Melo [this message]
2003-05-04 18:43 ` Steven Whitehouse
2003-05-06 6:46 ` David S. Miller
2003-05-01 20:55 ` Remains of seq_file conversion for DECnet, plus fixes (part 2) Steven Whitehouse
2003-05-01 20:57 ` Remains of seq_file conversion for DECnet, plus fixes (part 3) Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030502015409.GC5356@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=Steve@ChyGwyn.com \
--cc=davem@redhat.com \
--cc=hch@infradead.org \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@gw.chygwyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.