From: "H. J. Lu" <hjl@lucon.org>
To: Andreas Jaeger <aj@suse.de>
Cc: binutils@sources.redhat.com, gcc@gcc.gnu.org,
GNU C Library <libc-alpha@sources.redhat.com>,
Kenneth Albanowski <kjahds@kjahds.com>,
Mat Hostetter <mat@lcs.mit.edu>, Warner Losh <imp@village.org>,
linux-mips@linux-mips.org, Ron Guilmette <rfg@monkeys.com>,
Ralf Baechle <ralf@linux-mips.org>,
Linas Vepstas <linas@linas.org>,
Leonard Zubkoff <lnz@dandelion.com>,
"Steven J. Hill" <sjhill@cotw.com>,
linux-gcc@vger.kernel.org
Subject: PATCH: Don't use empy files in ld-elfvers
Date: Tue, 6 May 2003 08:41:19 -0700 [thread overview]
Message-ID: <20030506084119.A4370@lucon.org> (raw)
In-Reply-To: <hod6iwy26e.fsf@byrd.suse.de>; from aj@suse.de on Tue, May 06, 2003 at 09:17:13AM +0200
[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]
On Tue, May 06, 2003 at 09:17:13AM +0200, Andreas Jaeger wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
>
> > This is the beta release of binutils 2.14.90.0.1 for Linux, which is
> > based on binutils 2003 0505 in CVS on sourecs.redhat.com plus various
> > changes. It is purely for Linux.
> >
> > The Linux/mips support is added. You have to use
> >
> > # rpm --target=[mips|mipsel] -ta binutils-xx.xx.xx.xx.xx.tar.gz
> >
> > to build it. Or you can read mips/README in the source tree to apply
> > the mips patches and build it by hand.
> >
> > Please report any bugs related to binutils 2.14.90.0.1 to hjl@lucon.org.
>
> HJ,
>
> the package is broken, the testsuite fails since the following
> (empty!) files from the ld/testsuite are not part of the tarball:
>
>
> ./testsuite/ld-elfvers/vers25b.c
> ./testsuite/ld-elfvers/vers25b.dsym
> ./testsuite/ld-elfvers/vers25b.ver
> ./testsuite/ld-elfvers/vers26b.dsym
> ./testsuite/ld-elfvers/vers26b.ver
> ./testsuite/ld-elfvers/vers27b.dsym
> ./testsuite/ld-elfvers/vers27b.ver
> ./testsuite/ld-elfvers/vers27c.c
> ./testsuite/ld-elfvers/vers27c.dsym
> ./testsuite/ld-elfvers/vers27c.ver
>
It is not such a good idea to use empty files in CVS. I will check in
this patch. Please apply binutils-2.14.90.0.1-empty-test.patch to the
Linux binutils 2.14.90.0.1.
H.J.
[-- Attachment #2: binutils-2.14.90.0.1-empty-test.patch --]
[-- Type: text/plain, Size: 3415 bytes --]
2003-05-06 H.J. Lu <hjl@gnu.org>
* ld-elfvers/vers.exp (objdump_versionstuff): Support comment
in expected version file.
* ld-elfvers/vers25b.c: Add a line of comment.
* ld-elfvers/vers25b.dsym: Likwise.
* ld-elfvers/vers25b.ver: Likwise.
* ld-elfvers/vers26b.dsym: Likwise.
* ld-elfvers/vers26b.ver: Likwise.
* ld-elfvers/vers27b.dsym: Likwise.
* ld-elfvers/vers27b.ver: Likwise.
* ld-elfvers/vers27c.c: Likwise.
* ld-elfvers/vers27c.dsym: Likwise.
* ld-elfvers/vers27c.ver: Likwise.
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers.exp.empty 2003-05-05 14:46:50.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers.exp 2003-05-06 08:32:18.000000000 -0700
@@ -457,7 +457,11 @@ proc objdump_versionstuff { objdump obje
set f1 [open $tmpdir/objdump.out r]
set f2 [open $expectfile r]
- gets $f2 l2
+ while { [gets $f2 l2] != -1 } {
+ if { ![regexp "^#.*$" $l2] } then {
+ break
+ }
+ }
while { [gets $f1 l1] != -1 } {
if { [string match $l2 $l1] } then {
if { [gets $f2 l2] == -1 } then {
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.c.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.c 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+/* Empty file */
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file.
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.c.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.c 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+/* Empty file */
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
prev parent reply other threads:[~2003-05-06 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 5:33 The Linux binutils 2.14.90.0.1 is released H. J. Lu
[not found] ` <hod6iwy26e.fsf@byrd.suse.de>
2003-05-06 15:41 ` H. J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030506084119.A4370@lucon.org \
--to=hjl@lucon.org \
--cc=aj@suse.de \
--cc=binutils@sources.redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=imp@village.org \
--cc=kjahds@kjahds.com \
--cc=libc-alpha@sources.redhat.com \
--cc=linas@linas.org \
--cc=linux-gcc@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=lnz@dandelion.com \
--cc=mat@lcs.mit.edu \
--cc=ralf@linux-mips.org \
--cc=rfg@monkeys.com \
--cc=sjhill@cotw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.