From: Andi Kleen <ak@muc.de>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andi Kleen <ak@muc.de>,
torvalds@transmeta.com, akpm@digeo.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix .altinstructions linking failures
Date: Tue, 6 May 2003 21:56:14 +0200 [thread overview]
Message-ID: <20030506195614.GA23831@averell> (raw)
In-Reply-To: <20030506164441.GO9794@fs.tum.de>
On Tue, May 06, 2003 at 06:44:41PM +0200, Adrian Bunk wrote:
> <-- snip -->
>
> ...
> #ifdef MODULE
> static void proc_cpia_destroy(void)
> {
> remove_proc_entry("cpia", 0);
> }
> #endif /*MODULE*/
> ...
> static void __exit cpia_exit(void)
> {
> #ifdef CONFIG_PROC_FS
> proc_cpia_destroy();
> #endif
> }
The driver is buggy. The #ifdef MODULE needs to be removed and proc_cpia_destroy
be marked __exit instead, then things will be ok.
-Andi
next prev parent reply other threads:[~2003-05-06 19:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 6:30 [PATCH] Fix .altinstructions linking failures Andi Kleen
2003-05-06 16:44 ` Adrian Bunk
2003-05-06 19:56 ` Andi Kleen [this message]
2003-05-06 21:08 ` Andi Kleen
2003-05-06 21:25 ` Andrew Morton
2003-05-06 21:45 ` Andi Kleen
2003-05-07 9:23 ` Jörn Engel
2003-05-07 9:47 ` Andi Kleen
2003-05-07 10:16 ` Jörn Engel
2003-05-07 16:38 ` Greg KH
2003-05-10 8:50 ` Adrian Bunk
2003-05-10 15:41 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030506195614.GA23831@averell \
--to=ak@muc.de \
--cc=akpm@digeo.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.