All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J.A. Magallon" <jamagallon@able.es>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-hfsplus-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE] HFS+ driver
Date: Thu, 8 May 2003 23:34:01 +0200	[thread overview]
Message-ID: <20030508213401.GA3458@werewolf.able.es> (raw)
In-Reply-To: <Pine.LNX.4.44.0305071643030.5042-100000@serv>; from zippel@linux-m68k.org on Wed, May 07, 2003 at 17:06:59 +0200


On 05.07, Roman Zippel wrote:
> Hi,
> 
> I'm proud to announce a complete new version of the HFS+ fs driver. This 
> work was made possible by Ardis Technologies (www.ardistech.com). It's 
> based on the driver by Brad Boyer (http://sf.net/projects/linux-hfsplus).
> 

How about this ?

--- fs/hfsplus/options.c.orig	2003-05-08 23:28:09.000000000 +0200
+++ fs/hfsplus/options.c	2003-05-08 23:30:28.000000000 +0200
@@ -47,23 +47,6 @@
 }
 #endif
 
-/* My own little ultra-paranoid version of strtok (yes, there is strtok...) */
-static char *my_strtok(char *input, char **next, char delim)
-{
-	char *d;
-
-	if (!input || !*input || !next)
-		return NULL;
-
-	*next = NULL;
-	d = strchr(input, delim);
-	if (d) {
-		*d = '\0';
-		*next = d+1;
-	}
-	return input;
-}
-
 /* convert a "four byte character" to a 32 bit int with error checks */
 static int fill_fourchar(u32 *result, char *input)
 {
@@ -102,14 +85,16 @@
 /* input is the options passed to mount() as a string */
 int parse_options(char *input, struct hfsplus_sb_info *results)
 {
-	char *next, *curropt, *value;
+	char *curropt, *value;
 	int tmp;
 
 	if (!input)
 		return 1;
 
-	for (curropt = my_strtok(input, &next, ','); curropt != NULL;
-	     curropt = my_strtok(next, &next, ',')) {
+	while ((curropt = strsep(&input,",")) != NULL) {
+		if (!*curropt)
+			continue;
+
 		if ((value = strchr(curropt, '=')) != NULL)
 			*value++ = '\0';
 


-- 
J.A. Magallon <jamagallon@able.es>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.21-rc1-jam2 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))

  parent reply	other threads:[~2003-05-08 21:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-07 15:06 [ANNOUNCE] HFS+ driver Roman Zippel
2003-05-07 15:06 ` Roman Zippel
2003-05-07 15:40 ` David S. Miller
2003-05-07 15:40   ` David S. Miller
2003-05-07 16:14 ` Daniele Pala
2003-05-07 19:39 ` Brad Boyer
2003-05-07 19:39   ` Brad Boyer
2003-05-07 23:53   ` Roman Zippel
2003-05-07 23:53     ` Roman Zippel
2003-05-08 21:34 ` J.A. Magallon [this message]
2003-05-08 21:47   ` Brad Boyer
2003-05-08 22:12     ` J.A. Magallon
2003-05-08 22:50       ` Brad Boyer
2003-05-12  9:58       ` Andreas Schwab
2003-05-12  9:58         ` Andreas Schwab
  -- strict thread matches above, loose matches on Subject: below --
2003-05-07 15:55 Jeffrey Baker
2003-05-07 16:38 ` Miles Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030508213401.GA3458@werewolf.able.es \
    --to=jamagallon@able.es \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hfsplus-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.