From: Greg KH <greg@kroah.com>
To: Matt Domsch <Matt_Domsch@Dell.com>
Cc: mochel@osdl.org, alan@redhat.com, linux-kernel@vger.kernel.org,
jgarzik@redhat.com
Subject: Re: [RFC][PATCH] Dynamic PCI Device IDs
Date: Fri, 9 May 2003 17:11:34 -0700 [thread overview]
Message-ID: <20030510001134.GA3769@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0305061123490.7233-100000@humbolt.us.dell.com>
On Tue, May 06, 2003 at 11:35:17AM -0500, Matt Domsch wrote:
> > You can't just call driver_attach(), as the bus semaphore needs to be
> > locked before doing so. In short, you almost need to duplicate
> > bus_add_driver(), but not quite :)
>
> Right, and it seems to work. I made driver_attach non-static, declared
> it extern in pci.h, and call it in pci-driver.c while holding the bus
> semaphore and references to the driver and the bus. This also let me
> delete my probe_each_pci_dev() function and let the driver core
> handle it.
Nice, this looks much better. I don't have a problem with this patch
anymore. I'll wait for Pat to ack the driver core changes to see if he
agrees with them before sending this on.
thanks,
greg k-h
next prev parent reply other threads:[~2003-05-09 23:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 2:04 [RFC][PATCH] Dynamic PCI Device IDs Matt_Domsch
2003-05-06 3:56 ` Greg KH
2003-05-06 16:35 ` Matt Domsch
2003-05-10 0:11 ` Greg KH [this message]
2003-05-13 21:28 ` Patrick Mochel
2003-05-13 21:33 ` Patrick Mochel
-- strict thread matches above, loose matches on Subject: below --
2003-05-01 0:39 Matt_Domsch
2003-05-02 23:15 ` Greg KH
2003-05-05 5:37 ` Jeff Garzik
2003-05-06 0:17 ` Greg KH
2003-05-05 22:51 ` Matt Domsch
2003-05-06 0:15 ` Greg KH
2003-04-30 21:45 Matt Domsch
2003-04-30 21:53 ` Jeff Garzik
2003-04-30 22:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030510001134.GA3769@kroah.com \
--to=greg@kroah.com \
--cc=Matt_Domsch@Dell.com \
--cc=alan@redhat.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.