All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [patch] 2.4.21-rc2: fix sound/kahlua.c .text.exit error
Date: Sun, 11 May 2003 00:21:38 +0200	[thread overview]
Message-ID: <20030510222138.GT1107@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.55L.0305082213420.9139@freak.distro.conectiva>


drivers/sound/kahlua.c in 2.4.21-rc2 causes a .text.exit error at the 
final linking when compiled statically into a kernel with CONFIG_HOTPLUG 
enabled. The pointer to remove_one is __devexit_p and not discarded but 
the __exit remove_one is discarded.

The following patch is needed:


--- linux-2.4.21-rc2-full/drivers/sound/kahlua.c.old	2003-05-10 19:03:12.000000000 +0200
+++ linux-2.4.21-rc2-full/drivers/sound/kahlua.c	2003-05-10 19:03:41.000000000 +0200
@@ -182,7 +182,7 @@
 	return 0;
 }
 
-static void __exit remove_one(struct pci_dev *pdev)
+static void __devexit remove_one(struct pci_dev *pdev)
 {
 	struct address_info *hw_config = pci_get_drvdata(pdev);
 	sb_dsp_unload(hw_config, 0);
@@ -219,7 +219,7 @@
 	return pci_module_init(&kahlua_driver);
 }
 
-static void __exit kahlua_cleanup_module(void)
+static void __devexit kahlua_cleanup_module(void)
 {
 	return pci_unregister_driver(&kahlua_driver);
 }


Please apply for -rc3
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2003-05-10 22:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-09  1:15 Linux 2.4.21-rc2 Marcelo Tosatti
2003-05-09  3:43 ` Driver ordering from boot: or lilo.conf Mr. James W. Laferriere
2003-05-10 22:21 ` Adrian Bunk [this message]
2003-05-10 22:29 ` [patch] 2.4.21-rc2: fix ips.c .text.exit error Adrian Bunk
2003-05-12 18:19 ` Linux v2.4.21-rc2 changelog (was: Linux 2.4.21-rc2) Matthias Andree
2003-05-12 21:25 ` Linux 2.4.21-rc2 Jerome Chantelauze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030510222138.GT1107@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.