All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Riesen <alexander.riesen@synopsys.COM>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Russell King <rmk@arm.linux.org.uk>
Subject: Re: 2.5.69+bk: "sleeping function called from illegal context" on card release while shutting down
Date: Tue, 13 May 2003 19:33:01 +0200	[thread overview]
Message-ID: <20030513173301.GA4826@Synopsys.COM> (raw)
In-Reply-To: <20030513172114.GH32559@Synopsys.COM>

Alex Riesen, Tue, May 13, 2003 19:21:14 +0200:
> Paul Fulghum, Tue, May 13, 2003 17:31:01 +0200:
> > Individual PCMCIA drivers need to be updated to call
> > thier release function directly when processing a
> > CARD_RELEASE message instead of from a timer procedure.
> > 
> > Similar to this patch for synclink_cs.c:
> ...
> > -		    mod_timer(&link->release, jiffies + HZ/20);
> > +		    mgslpc_release((u_long)link);
> 
> Tried that. This time the trace looks different:
> 

I was probably too fast with the conclusions. It seemed I didn't update
modules (though I and bash history distinctly remember doing that).

I cannot reproduce the trace anymore. The patch was:

--- pcnet_cs.c	2003-04-30 06:17:05.000000000 +0200
+++ pcnet_cs.c	2003-05-13 19:31:12.000000000 +0200
@@ -848,7 +848,7 @@ static int pcnet_event(event_t event, in
 	link->state &= ~DEV_PRESENT;
 	if (link->state & DEV_CONFIG) {
 	    netif_device_detach(&info->dev);
-	    mod_timer(&link->release, jiffies + HZ/20);
+	    pcnet_release((u_long)link);
 	}
 	break;
     case CS_EVENT_CARD_INSERTION:

  parent reply	other threads:[~2003-05-13 17:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-13 13:57 2.5.69+bk: "sleeping function called from illegal context" on card release while shutting down Alex Riesen
2003-05-13 14:58 ` Felipe Alfaro Solana
2003-05-13 15:31   ` Paul Fulghum
2003-05-13 16:08     ` Russell King
2003-05-13 17:21     ` Alex Riesen
2003-05-13 17:28       ` Paul Fulghum
2003-05-13 17:33       ` Alex Riesen [this message]
2003-05-13 21:52     ` Felipe Alfaro Solana
  -- strict thread matches above, loose matches on Subject: below --
2003-05-13 18:46 Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030513173301.GA4826@Synopsys.COM \
    --to=alexander.riesen@synopsys.com \
    --cc=felipe_alfaro@linuxmail.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulkf@microgate.com \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.